Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Discover action types #53

Merged
merged 38 commits into from
Jan 29, 2024
Merged

Discover action types #53

merged 38 commits into from
Jan 29, 2024

Conversation

dboulware
Copy link
Collaborator

This PR updates scos-action dependency to 8.0.0. Due to changes in scos-actions 8.0.0 this PR makes the following changes:

  • Removes example calibration files
  • No longer creates an instance of the TekRSASigan in hardware package
  • Relies on a new DEVICE_MODEL setting to determine which action configs to use because the TekRSASigan instance is no longer available
  • Removes calibration tests
  • Changes number ffts to 320e3
    Additional changes unrelated to scos-actions include:
  • Add plugin_version, firmware_version, and api_version to TekRSASigan

Due to the above changes, this also includes a a major version increase.

aromanielloNTIA and others added 30 commits October 31, 2023 10:08
@aromanielloNTIA
Update scos-actions branch for testing
99ccc8d
@aromanielloNTIA
Add testing config
ec8dc56
@dboulware
scos-actions branch testing.
d120239
@aromanielloNTIA
Add noise-diode-off testing config
2cc4da9
@aromanielloNTIA
Merge branch 'main' into add-percentile-detector
c288a88
@aromanielloNTIA
Add firmware and API version properties
209f7ac
@aromanielloNTIA
Add new properties to unit tests
01561c2
@aromanielloNTIA
Bump minor version to 4.1.0
f4bb711
@aromanielloNTIA
Update required scos-actions version
ab62b2c
@aromanielloNTIA
Delete testing configs
e798388
@aromanielloNTIA
Update nffts in SEA data product configs
ddb14e1
@dboulware
add no filter cal action for testing.
aa42b99
@aromanielloNTIA
Merge branch 'add-percentile-detector' into scos-actions-7.1.0
23cfe5f
@aromanielloNTIA
Delete example calibration files
b5b6d05
@dboulware
actions branch
21dcf3b
@dboulware
Merge branch 'scos-actions-7.1.0' of https://github.com/NTIA/scos-tekrsa
0986ad3 
 into empty_calibration_params
@dboulware
expose signal_analyzer in discover.
f6a08c6
@dboulware
Only load actions in discover. Use a setting for the device model.
b686c7c
@dboulware
Don't create sigan.
7eaf913
@dboulware
optional cals in sigan constructor.
a83cf3d
@dboulware
remove bad import and use self.sensor_calibration.
2b557c6
@dboulware
Add optional switches dictionary to TekRSASigan and pass to power_cycle.
dfefabf
@dboulware
remove switches from power_cycle_and_connect call.
0199054
@dboulware
Instantiate signal_analyzer and expose in discover if not running mig…
79f71b5 
…rations.
@dboulware
set sigan to None when running migration.
a9a6986
@dboulware
log running migrations.
effd540
@dboulware
load switches before creating tekrsa.
8237df5
@dboulware
Don't create sigan.
67fe159
@dboulware
Return to not initializing sigan for testing.
3ae55c5
@dboulware
scos-actions 8.0.0 and remove switch_configs_dir setting.
58dd731
aromanielloNTIA
aromanielloNTIA approved these changes Jan 29, 2024
View reviewed changes
Copy link
Member

@aromanielloNTIA aromanielloNTIA left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I made two commits with relatively small changes to:

  • Remove most SEA action configs, since the changes in Initialization and users app scos-sensor#267 will let us develop and load actions per-sensor without having YAML files here. I kept baseline action configurations only.
  • Update the README to remove mention of example calibration files in this repository which have been removed.

Otherwise, please see my one comment below. Everything else looks good.

src/scos_tekrsa/settings.py Show resolved Hide resolved
@aromanielloNTIA aromanielloNTIA mentioned this pull request Jan 29, 2024
Closed
@aromanielloNTIA
use model property instead of device_name
9e3d509 
Consistency with base sigan interface
@aromanielloNTIA aromanielloNTIA merged commit adb3db8 into main Jan 29, 2024
4 checks passed
@aromanielloNTIA aromanielloNTIA deleted the discover_action_types branch January 29, 2024 19:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aromanielloNTIA aromanielloNTIA aromanielloNTIA approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@dboulware @aromanielloNTIA