Handle Docker Compose configuration entirely with environment variables #282
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…nsor into all-config-with-env
Updated from old "docker-compose"
…-config-with-env
jhazentia
requested changes
Dec 13, 2024
jhazentia
approved these changes
Jan 14, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #279 by adding new environment variables
SSD_DEVICEandAPI_SHM_SIZE.Now,
SSD_DEVICEis used to provide the host's storage device path to the API container. This environment variable is used by the SEA edge compute action to get diagnostic SSD SMART data. The default included in theenv.templatefile is/dev/nvme0n1. This default could cause missing metadata when using the SEA action if theSSD_DEVICEis not an SSD. SCOS Actions handling of this new environment variable was added in 11.1.0 (NTIA/scos-actions#126).API_SHM_SIZEis used to set the shared memory in the API container, and a default is provided keeping it at 16 GB. This is used to provide sufficient shared memory to the Ray package for parallel processing of large IQ captures.After merging this, the following need to be added to the environment variables documentation in the wiki:
/dev/shm) in the API container. Thisis currently used to allocate shared memory for parallel processing of IQ data with Ray.
/dev/sda/) which is mapped to/dev/nvme0n1withinthe API container. This is currently only used to retrieve SSD SMART diagnostics (in
SCOS Actions).