Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merge SEA features #61

Merged
merged 312 commits into from
Jan 5, 2023
Merged

Merge SEA features #61

merged 312 commits into from
Jan 5, 2023

Conversation

aromanielloNTIA
Copy link
Member

  • Dependencies:
    • Updates its_preselector 2.1.0 -> 3.0.0
    • Adds psutil>=5.9.4
    • Adds ray>=2.0.0
  • Adds NASCTN SEA data product action, along with a corresponding test YAML config
  • Updates Y-Factor calibration:
    • In the action, calculates IIR filter ENBW on action initialization instead of during action runtime, if using IIR filtering
    • Suppresses pointless warnings when configuring sigan
    • Calibration now expects preselector temperature values to be returned in Celsius rather than Fahrenheit.
  • Metadata
    • Proactively adds new SigMF extension "ntia-nasctn-sea" with version "v0.2" ahead of future specification of this extension
    • Adds a set_num_channels method to the SigMF builder to support setting the global `core:num_channels" field (note: this is not part of the v0.0.1 SigMF spec. This is part of a larger fragmentation described in NTIA/SigMF lags gnuradio/SigMF #29 )
    • Adds an optional extra_entries parameter to set_capture in the SigMF builder. This is out-of-spec, but used as a placeholder to add metadata to captures before the ntia-nasctn-sea extension is fleshed out.
  • Adds a convert_celsius_to_fahrenheit method to signal_processing/unit_conversion.py

@aromanielloNTIA aromanielloNTIA added the enhancement New feature or request label Jan 5, 2023
@aromanielloNTIA
Copy link
Member Author

A few potentially 'breaking' changes are included in this:

  • Metadata for all actions will now include a ntia-nasctn-sea SigMF extension listing
  • There are 2 new dependencies and an updated dependency with a major version update
  • Actions now require that a preselector has rf_paths in the sensor definition, which could cause a situation where previously recognized preselectors are no longer recognized. This is not an issue for any real-world use case.
  • probably most important Preselectors will need to be reconfigured to report temperatures in Celsius instead of Fahrenheit. This is already done for all seadog sensors.

Due mostly to the last bullet point, I think a major version increment makes sense. Open to discourse here.

Copy link
Member

@jhazentia jhazentia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me

@aromanielloNTIA aromanielloNTIA merged commit c653025 into master Jan 5, 2023
@aromanielloNTIA aromanielloNTIA deleted the nasctn-sea branch January 3, 2024 19:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants