Skip to content

MotorGroupIOC#66

Open
malitsky wants to merge 4 commits intoNSLS-II:masterfrom
malitsky:add_motor_group_ioc
Open

MotorGroupIOC#66
malitsky wants to merge 4 commits intoNSLS-II:masterfrom
malitsky:add_motor_group_ioc

Conversation

@malitsky
Copy link

No description provided.

@codecov-io
Copy link

codecov-io commented May 16, 2019

Codecov Report

Merging #66 into master will increase coverage by 3.43%.
The diff coverage is 96.55%.

Impacted file tree graph

@@            Coverage Diff            @@
##           master     #66      +/-   ##
=========================================
+ Coverage   52.16%   55.6%   +3.43%     
=========================================
  Files          11      12       +1     
  Lines         692     750      +58     
=========================================
+ Hits          361     417      +56     
- Misses        331     333       +2
Impacted Files Coverage Δ
nslsii/tests/test_epstwostate_ioc.py 100% <ø> (ø)
nslsii/tests/temperature_controllers_test.py 100% <100%> (ø) ⬆️
nslsii/tests/test_motorgroup_ioc.py 96.42% <96.42%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update bd076a7...0e1ccc2. Read the comment docs.

Copy link
Contributor

@awalter-bnl awalter-bnl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good to me

@codecov-commenter
Copy link

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

❌ Patch coverage is 96.55172% with 2 lines in your changes missing coverage. Please review.
✅ Project coverage is 55.60%. Comparing base (bd076a7) to head (0e1ccc2).
⚠️ Report is 709 commits behind head on master.

Files with missing lines Patch % Lines
nslsii/tests/test_motorgroup_ioc.py 96.42% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master      #66      +/-   ##
==========================================
+ Coverage   52.16%   55.60%   +3.43%     
==========================================
  Files          11       12       +1     
  Lines         692      750      +58     
==========================================
+ Hits          361      417      +56     
- Misses        331      333       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants