Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Latest OS-HPXML #1308

Merged
merged 26 commits into from
Oct 31, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
26 commits
Select commit Hold shift + click to select a range
dbab8e2
Merge commit '7f5ccccc9c8fa25a0bb2289f4d933bb328325283' into latest-o…
joseph-robertson Oct 3, 2024
7f5cccc
Squashed 'resources/hpxml-measures/' changes from 69b9cb792496..e770f…
joseph-robertson Oct 3, 2024
1e736d7
Update ResStockArguments README.
joseph-robertson Oct 3, 2024
5ee112d
Move update_args_hash into resource file.
joseph-robertson Oct 4, 2024
af908df
Latest results.
Oct 4, 2024
4b344ed
Merge commit '867a5e2a343f4081e39935815fa8c048ecde8e2c' into latest-o…
joseph-robertson Oct 7, 2024
867a5e2
Squashed 'resources/hpxml-measures/' changes from e770f4230706..afdd3…
joseph-robertson Oct 7, 2024
461198a
Latest results.
Oct 7, 2024
c25e96f
Merge branch 'develop' into latest-os-hpxml
joseph-robertson Oct 14, 2024
18d1a24
Merge commit 'f5048f2b0c8fca62466ccad8263eaf13c3049c8b' into latest-o…
joseph-robertson Oct 14, 2024
f5048f2
Squashed 'resources/hpxml-measures/' changes from afdd3884ed15..9bb1a…
joseph-robertson Oct 14, 2024
0db16a2
Merge branch 'develop' into latest-os-hpxml
joseph-robertson Oct 23, 2024
c514aa4
Merge commit 'cf9002cee78cb7f0932b045aa56caaaccbe8e2fd' into latest-o…
joseph-robertson Oct 23, 2024
cf9002c
Squashed 'resources/hpxml-measures/' changes from 9bb1ac4ba678..6980e…
joseph-robertson Oct 23, 2024
552911b
Add water_heater_backup_heating_capacity=auto to lookup.
joseph-robertson Oct 23, 2024
e25c9d5
Latest results.
Oct 23, 2024
10d9785
Merge branch 'develop' into latest-os-hpxml
joseph-robertson Oct 25, 2024
4001b48
Squashed 'resources/hpxml-measures/' changes from 6980e23d12d3..76951…
joseph-robertson Oct 25, 2024
76f32ac
Merge commit '4001b48b5c1568e4469130e04b218e0a4613a3e7' into latest-o…
joseph-robertson Oct 25, 2024
6216214
Point to correct defaulting methods.
joseph-robertson Oct 25, 2024
4f0d2fb
Latest results.
Oct 26, 2024
6918171
Squashed 'resources/hpxml-measures/' changes from 76951e1802ad..1d56c…
joseph-robertson Oct 30, 2024
04f9bf5
Merge commit '6918171af8e728db717f1c00edb2ccaf4a57fde6' into latest-o…
joseph-robertson Oct 30, 2024
12c0bdb
Fix merge conflict that changed TimeStep to Timestep.
joseph-robertson Oct 30, 2024
8d5f7e9
Fix merge conflict that changed hash_to_string.
joseph-robertson Oct 30, 2024
5b7699f
Try updating integration-tests job with python 3.11.
joseph-robertson Oct 30, 2024
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions .github/workflows/config.yml
Original file line number Diff line number Diff line change
Expand Up @@ -142,6 +142,10 @@ jobs:
with:
ref: ${{ github.head_ref }}

- uses: actions/setup-python@v5
with:
python-version: '3.11'

- name: Download and Install OpenStudio
run: |
export OS_DEBFILE="OpenStudio-$OPENSTUDIO_VER+$OPENSTUDIO_SHA-$OPENSTUDIO_PLATFORM.$OPENSTUDIO_EXT"
Expand Down
27 changes: 25 additions & 2 deletions docs/read_the_docs/source/workflow_inputs/characteristics.rst
Original file line number Diff line number Diff line change
Expand Up @@ -62768,7 +62768,7 @@ Arguments
- gal
- Double
- auto
- Nominal volume of water heater tank. Only applies to storage water heater, heat pump water heater, and space-heating boiler with storage tank. If not provided, the OS-HPXML default (see `Conventional Storage <https://openstudio-hpxml.readthedocs.io/en/v1.8.1/workflow_inputs.html#conventional-storage>`_, `Heat Pump <https://openstudio-hpxml.readthedocs.io/en/v1.8.1/workflow_inputs.html#heat-pump>`_, `Combi Boiler w/ Storage <https://openstudio-hpxml.readthedocs.io/en/v1.8.1/workflow_inputs.html#combi-boiler-w-storage>`_) is used.
- Nominal volume of water heater tank. If not provided, the OS-HPXML default (see `Conventional Storage <https://openstudio-hpxml.readthedocs.io/en/v1.8.1/workflow_inputs.html#conventional-storage>`_, `Heat Pump <https://openstudio-hpxml.readthedocs.io/en/v1.8.1/workflow_inputs.html#heat-pump>`_, `Combi Boiler w/ Storage <https://openstudio-hpxml.readthedocs.io/en/v1.8.1/workflow_inputs.html#combi-boiler-w-storage>`_) is used.
* - ``water_heater_efficiency_type``
- true
-
Expand Down Expand Up @@ -62798,7 +62798,13 @@ Arguments
- Btu/hr
- Double
- auto
- Heating capacity. Only applies to storage water heater. If not provided, the OS-HPXML default (see `Conventional Storage <https://openstudio-hpxml.readthedocs.io/en/v1.8.1/workflow_inputs.html#conventional-storage>`_) is used.
- Heating capacity. Only applies to storage water heater and heat pump water heater (compressor). If not provided, the OS-HPXML default (see `Conventional Storage <https://openstudio-hpxml.readthedocs.io/en/v1.8.1/workflow_inputs.html#conventional-storage>`_, `Heat Pump <https://openstudio-hpxml.readthedocs.io/en/v1.8.1/workflow_inputs.html#heat-pump>`_) is used.
* - ``water_heater_backup_heating_capacity``
- false
- Btu/hr
- Double
- auto
- Backup heating capacity for a heat pump water heater. If not provided, the OS-HPXML default (see `Heat Pump <https://openstudio-hpxml.readthedocs.io/en/v1.8.1/workflow_inputs.html#heat-pump>`_) is used.
* - ``water_heater_standby_loss``
- false
- F/hr
Expand Down Expand Up @@ -62868,6 +62874,7 @@ From ``project_national`` the list of options, option stock sturation, and optio
- ``water_heater_usage_bin``
- ``water_heater_recovery_efficiency``
- ``water_heater_heating_capacity``
- ``water_heater_backup_heating_capacity``
- ``water_heater_standby_loss``
- ``water_heater_jacket_rvalue``
- ``water_heater_setpoint_temperature``
Expand All @@ -62887,6 +62894,7 @@ From ``project_national`` the list of options, option stock sturation, and optio
- auto
- 0
- auto
- auto
- 0
- 0
- 125
Expand All @@ -62905,6 +62913,7 @@ From ``project_national`` the list of options, option stock sturation, and optio
- auto
- 0
- auto
- auto
- 0
- 0
- 125
Expand All @@ -62923,6 +62932,7 @@ From ``project_national`` the list of options, option stock sturation, and optio
- auto
- 0
- auto
- auto
- 0
- 0
- 125
Expand All @@ -62941,6 +62951,7 @@ From ``project_national`` the list of options, option stock sturation, and optio
- auto
- 0
- auto
- auto
- 0
- 0
- 125
Expand All @@ -62959,6 +62970,7 @@ From ``project_national`` the list of options, option stock sturation, and optio
- auto
- 0
- auto
- auto
- 0
- 0
- 125
Expand All @@ -62977,6 +62989,7 @@ From ``project_national`` the list of options, option stock sturation, and optio
- auto
- 0
- auto
- auto
- 0
- 0
- 125
Expand All @@ -62995,6 +63008,7 @@ From ``project_national`` the list of options, option stock sturation, and optio
- auto
- 0.78
- auto
- auto
- 0
- 0
- 125
Expand All @@ -63013,6 +63027,7 @@ From ``project_national`` the list of options, option stock sturation, and optio
- auto
- 0.9
- auto
- auto
- 0
- 0
- 125
Expand All @@ -63031,6 +63046,7 @@ From ``project_national`` the list of options, option stock sturation, and optio
- auto
- 0.78
- auto
- auto
- 0
- 0
- 125
Expand All @@ -63049,6 +63065,7 @@ From ``project_national`` the list of options, option stock sturation, and optio
- auto
- 0.78
- auto
- auto
- 0
- 0
- 125
Expand All @@ -63067,6 +63084,7 @@ From ``project_national`` the list of options, option stock sturation, and optio
- auto
- 0.76
- auto
- auto
- 0
- 0
- 125
Expand All @@ -63085,6 +63103,7 @@ From ``project_national`` the list of options, option stock sturation, and optio
- auto
- 0
- auto
- auto
- 0
- 0
- 125
Expand All @@ -63103,6 +63122,7 @@ From ``project_national`` the list of options, option stock sturation, and optio
- auto
- 0.76
- auto
- auto
- 0
- 0
- 125
Expand All @@ -63121,6 +63141,7 @@ From ``project_national`` the list of options, option stock sturation, and optio
- auto
- 0.78
- auto
- auto
- 0
- 0
- 125
Expand All @@ -63139,6 +63160,7 @@ From ``project_national`` the list of options, option stock sturation, and optio
- auto
- 0.76
- auto
- auto
- 0
- 0
- 125
Expand All @@ -63157,6 +63179,7 @@ From ``project_national`` the list of options, option stock sturation, and optio
- auto
- 0
- auto
- auto
- 0
- 0
- 125
Expand Down
8 changes: 5 additions & 3 deletions measures/ApplyUpgrade/measure.rb
Original file line number Diff line number Diff line change
Expand Up @@ -263,15 +263,17 @@ def run(model, runner, user_arguments)
# Get measure name and arguments associated with the option
options_measure_args, _errors = get_measure_args_from_option_names(lookup_csv_data, [option_name], parameter_name, lookup_file, runner)
options_measure_args[option_name].each do |measure_subdir, args_hash|
update_args_hash(measures, measure_subdir, args_hash, false)
update_args_hash(measures, measure_subdir, args_hash)
end
end

if halt_workflow(runner, measures)
return false
end

measures['ResStockArguments'] = [{}] if !measures.keys.include?('ResStockArguments') # upgrade is via another measure
if !measures.keys.include?('ResStockArguments') # upgrade is via another measure
measures['ResStockArguments'] = [{}]
end

# Add measure arguments from existing building if needed
parameters = get_parameters_ordered_from_options_lookup_tsv(lookup_csv_data, characteristics_dir)
Expand All @@ -290,7 +292,7 @@ def run(model, runner, user_arguments)

new_args_hash[k] = v
end
update_args_hash(measures, measure_subdir, new_args_hash, false)
update_args_hash(measures, measure_subdir, new_args_hash)
end
end
end
Expand Down
6 changes: 3 additions & 3 deletions measures/ApplyUpgrade/measure.xml
Original file line number Diff line number Diff line change
Expand Up @@ -3,8 +3,8 @@
<schema_version>3.1</schema_version>
<name>apply_upgrade</name>
<uid>33f1654c-f734-43d1-b35d-9d2856e41b5a</uid>
<version_id>e0b6d3af-6941-45e2-8627-9d8f568ebe1a</version_id>
<version_modified>2024-09-04T23:38:38Z</version_modified>
<version_id>bdafc4c0-e705-4aec-bcd1-4e662b31f968</version_id>
<version_modified>2024-10-04T15:40:22Z</version_modified>
<xml_checksum>9339BE01</xml_checksum>
<class_name>ApplyUpgrade</class_name>
<display_name>Apply Upgrade</display_name>
Expand Down Expand Up @@ -6342,7 +6342,7 @@
<filename>measure.rb</filename>
<filetype>rb</filetype>
<usage_type>script</usage_type>
<checksum>8E47BE40</checksum>
<checksum>F73DDD7C</checksum>
</file>
<file>
<filename>constants.rb</filename>
Expand Down
2 changes: 1 addition & 1 deletion measures/BuildExistingModel/measure.rb
Original file line number Diff line number Diff line change
Expand Up @@ -323,7 +323,7 @@ def run(model, runner, user_arguments)
print_option_assignment(parameter_name, option_name, runner)
options_measure_args, _errors = get_measure_args_from_option_names(lookup_csv_data, [option_name], parameter_name, lookup_file, runner)
options_measure_args[option_name].each do |measure_subdir, args_hash|
update_args_hash(measures, measure_subdir, args_hash, false)
update_args_hash(measures, measure_subdir, args_hash)
end
end

Expand Down
6 changes: 3 additions & 3 deletions measures/BuildExistingModel/measure.xml
Original file line number Diff line number Diff line change
Expand Up @@ -3,8 +3,8 @@
<schema_version>3.1</schema_version>
<name>build_existing_model</name>
<uid>dedf59bb-3b88-4f16-8755-2c1ff5519cbf</uid>
<version_id>be99be23-ddd9-49c4-804a-cb9853764e3e</version_id>
<version_modified>2024-09-04T21:01:10Z</version_modified>
<version_id>a901b49d-d749-45b2-94fc-d5122935fd30</version_id>
<version_modified>2024-10-04T15:40:23Z</version_modified>
<xml_checksum>2C38F48B</xml_checksum>
<class_name>BuildExistingModel</class_name>
<display_name>Build Existing Model</display_name>
Expand Down Expand Up @@ -349,7 +349,7 @@
<filename>measure.rb</filename>
<filetype>rb</filetype>
<usage_type>script</usage_type>
<checksum>18614B0C</checksum>
<checksum>E660DFB7</checksum>
</file>
</files>
</measure>
15 changes: 13 additions & 2 deletions measures/ResStockArguments/README.md
Original file line number Diff line number Diff line change
Expand Up @@ -3160,7 +3160,7 @@ The location of water heater. If not provided, the OS-HPXML default (see <a href

**Water Heater: Tank Volume**

Nominal volume of water heater tank. Only applies to storage water heater, heat pump water heater, and space-heating boiler with storage tank. If not provided, the OS-HPXML default (see <a href='https://openstudio-hpxml.readthedocs.io/en/v1.8.1/workflow_inputs.html#conventional-storage'>Conventional Storage</a>, <a href='https://openstudio-hpxml.readthedocs.io/en/v1.8.1/workflow_inputs.html#heat-pump'>Heat Pump</a>, <a href='https://openstudio-hpxml.readthedocs.io/en/v1.8.1/workflow_inputs.html#combi-boiler-w-storage'>Combi Boiler w/ Storage</a>) is used.
Nominal volume of water heater tank. If not provided, the OS-HPXML default (see <a href='https://openstudio-hpxml.readthedocs.io/en/v1.8.1/workflow_inputs.html#conventional-storage'>Conventional Storage</a>, <a href='https://openstudio-hpxml.readthedocs.io/en/v1.8.1/workflow_inputs.html#heat-pump'>Heat Pump</a>, <a href='https://openstudio-hpxml.readthedocs.io/en/v1.8.1/workflow_inputs.html#combi-boiler-w-storage'>Combi Boiler w/ Storage</a>) is used.

- **Name:** ``water_heater_tank_volume``
- **Type:** ``String``
Expand Down Expand Up @@ -3219,7 +3219,7 @@ Ratio of energy delivered to water heater to the energy content of the fuel cons

**Water Heater: Heating Capacity**

Heating capacity. Only applies to storage water heater. If not provided, the OS-HPXML default (see <a href='https://openstudio-hpxml.readthedocs.io/en/v1.8.1/workflow_inputs.html#conventional-storage'>Conventional Storage</a>) is used.
Heating capacity. Only applies to storage water heater and heat pump water heater (compressor). If not provided, the OS-HPXML default (see <a href='https://openstudio-hpxml.readthedocs.io/en/v1.8.1/workflow_inputs.html#conventional-storage'>Conventional Storage</a>, <a href='https://openstudio-hpxml.readthedocs.io/en/v1.8.1/workflow_inputs.html#heat-pump'>Heat Pump</a>) is used.

- **Name:** ``water_heater_heating_capacity``
- **Type:** ``String``
Expand All @@ -3228,6 +3228,17 @@ Heating capacity. Only applies to storage water heater. If not provided, the OS-

<br/>

**Water Heater: Backup Heating Capacity**

Backup heating capacity for a heat pump water heater. If not provided, the OS-HPXML default (see <a href='https://openstudio-hpxml.readthedocs.io/en/v1.8.1/workflow_inputs.html#heat-pump'>Heat Pump</a>) is used.

- **Name:** ``water_heater_backup_heating_capacity``
- **Type:** ``String``

- **Required:** ``false``

<br/>

**Water Heater: Standby Loss**

The standby loss of water heater. Only applies to space-heating boilers. If not provided, the OS-HPXML default (see <a href='https://openstudio-hpxml.readthedocs.io/en/v1.8.1/workflow_inputs.html#combi-boiler-w-storage'>Combi Boiler w/ Storage</a>) is used.
Expand Down
4 changes: 2 additions & 2 deletions measures/ResStockArguments/measure.rb
Original file line number Diff line number Diff line change
Expand Up @@ -853,9 +853,9 @@ def modify_setpoint_schedule(schedule, offset_magnitude, offset_schedule)
def get_heating_and_cooling_seasons(args, weather)
latitude = args[:site_latitude]
latitude = nil if latitude == Constants::Auto
latitude = HPXMLDefaults.get_default_latitude(latitude, weather)
latitude = Defaults.get_latitude(latitude, weather)

heating_months, cooling_months = HVAC.get_default_heating_and_cooling_seasons(weather, latitude)
heating_months, cooling_months = HVAC.get_building_america_hvac_seasons(weather, latitude)
sim_calendar_year = Location.get_sim_calendar_year(nil, weather)

return heating_months, cooling_months, sim_calendar_year
Expand Down
21 changes: 15 additions & 6 deletions measures/ResStockArguments/measure.xml
Original file line number Diff line number Diff line change
Expand Up @@ -3,8 +3,8 @@
<schema_version>3.1</schema_version>
<name>res_stock_arguments</name>
<uid>c984bb9e-4ac4-4930-a399-9d23f8f6936a</uid>
<version_id>534c899e-ac51-4052-92ce-876e8ee58146</version_id>
<version_modified>2024-09-25T03:27:57Z</version_modified>
<version_id>52dee2c0-3ac8-4c59-a25b-1e77d0983b1d</version_id>
<version_modified>2024-10-25T22:51:52Z</version_modified>
<xml_checksum>2C38F48B</xml_checksum>
<class_name>ResStockArguments</class_name>
<display_name>ResStock Arguments</display_name>
Expand Down Expand Up @@ -4479,7 +4479,7 @@
<argument>
<name>water_heater_tank_volume</name>
<display_name>Water Heater: Tank Volume</display_name>
<description>Nominal volume of water heater tank. Only applies to storage water heater, heat pump water heater, and space-heating boiler with storage tank. If not provided, the OS-HPXML default (see &lt;a href='https://openstudio-hpxml.readthedocs.io/en/v1.8.1/workflow_inputs.html#conventional-storage'&gt;Conventional Storage&lt;/a&gt;, &lt;a href='https://openstudio-hpxml.readthedocs.io/en/v1.8.1/workflow_inputs.html#heat-pump'&gt;Heat Pump&lt;/a&gt;, &lt;a href='https://openstudio-hpxml.readthedocs.io/en/v1.8.1/workflow_inputs.html#combi-boiler-w-storage'&gt;Combi Boiler w/ Storage&lt;/a&gt;) is used.</description>
<description>Nominal volume of water heater tank. If not provided, the OS-HPXML default (see &lt;a href='https://openstudio-hpxml.readthedocs.io/en/v1.8.1/workflow_inputs.html#conventional-storage'&gt;Conventional Storage&lt;/a&gt;, &lt;a href='https://openstudio-hpxml.readthedocs.io/en/v1.8.1/workflow_inputs.html#heat-pump'&gt;Heat Pump&lt;/a&gt;, &lt;a href='https://openstudio-hpxml.readthedocs.io/en/v1.8.1/workflow_inputs.html#combi-boiler-w-storage'&gt;Combi Boiler w/ Storage&lt;/a&gt;) is used.</description>
<type>String</type>
<units>gal</units>
<required>false</required>
Expand Down Expand Up @@ -4556,7 +4556,16 @@
<argument>
<name>water_heater_heating_capacity</name>
<display_name>Water Heater: Heating Capacity</display_name>
<description>Heating capacity. Only applies to storage water heater. If not provided, the OS-HPXML default (see &lt;a href='https://openstudio-hpxml.readthedocs.io/en/v1.8.1/workflow_inputs.html#conventional-storage'&gt;Conventional Storage&lt;/a&gt;) is used.</description>
<description>Heating capacity. Only applies to storage water heater and heat pump water heater (compressor). If not provided, the OS-HPXML default (see &lt;a href='https://openstudio-hpxml.readthedocs.io/en/v1.8.1/workflow_inputs.html#conventional-storage'&gt;Conventional Storage&lt;/a&gt;, &lt;a href='https://openstudio-hpxml.readthedocs.io/en/v1.8.1/workflow_inputs.html#heat-pump'&gt;Heat Pump&lt;/a&gt;) is used.</description>
<type>String</type>
<units>Btu/hr</units>
<required>false</required>
<model_dependent>false</model_dependent>
</argument>
<argument>
<name>water_heater_backup_heating_capacity</name>
<display_name>Water Heater: Backup Heating Capacity</display_name>
<description>Backup heating capacity for a heat pump water heater. If not provided, the OS-HPXML default (see &lt;a href='https://openstudio-hpxml.readthedocs.io/en/v1.8.1/workflow_inputs.html#heat-pump'&gt;Heat Pump&lt;/a&gt;) is used.</description>
<type>String</type>
<units>Btu/hr</units>
<required>false</required>
Expand Down Expand Up @@ -7684,7 +7693,7 @@
<filename>README.md</filename>
<filetype>md</filetype>
<usage_type>readme</usage_type>
<checksum>7C3E7B89</checksum>
<checksum>B8A69924</checksum>
</file>
<file>
<filename>README.md.erb</filename>
Expand All @@ -7701,7 +7710,7 @@
<filename>measure.rb</filename>
<filetype>rb</filetype>
<usage_type>script</usage_type>
<checksum>1B03697A</checksum>
<checksum>65EE211F</checksum>
</file>
<file>
<filename>constants.rb</filename>
Expand Down
Loading