Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Airloop naming convention change. #1856

Open
wants to merge 18 commits into
base: nrcan
Choose a base branch
from
Open

Airloop naming convention change. #1856

wants to merge 18 commits into from

Conversation

phylroy
Copy link
Collaborator

@phylroy phylroy commented Nov 26, 2024

Pull request overview

  • Fixes #ISSUENUMBERHERE (IF THIS IS A DEFECT)

Pull Request Author

  • Method changes or additions
  • Data changes or additions
  • Added tests for added methods
  • If methods have been deprecated, update rest of code to use the new methods
  • Documented new methods using yard syntax
  • Resolved yard documentation errors for new code (ran bundle exec rake doc)
  • Resolved rubocop syntax errors for new code (ran bundle exec rake rubocop)
  • All new and existing tests passes
  • If the code adds new require statements, ensure these are in core ruby or add to the gemspec

Review Checklist

This will not be exhaustively relevant to every PR.

  • Perform a code review on GitHub
  • All related changes have been implemented: method additions, changes, tests
  • Check rubocop errors
  • Check yard doc errors
  • If fixing a defect, verify by running develop branch and reproducing defect, then running PR and reproducing fix
  • If a new feature, test the new feature and try creative ways to break it
  • CI status: all green or justified

plopez and others added 18 commits September 6, 2024 18:07
- Updated the HVAC system naming conventions in the NECB2011 module to include additional options for air source heat pumps with different supplemental fuels.
- Modified the 'sys_htg' parameter in the system name parameters to include 'ashp>c-g' for air source heat pumps with natural gas as the supplemental fuel and 'ashp>c-e' for air source heat pumps with electricity as the supplemental fuel.
- Made the necessary changes in the 'hvac_system_4.rb', 'hvac_system_1_single_speed.rb', 'hvac_systems.rb', and 'hvac_system_3_and_8_single_speed.rb' files.
Including boiler fuel type and capacity ratio changes, SHW fuel type changes, and changes from master.
Update from nrcan branch
Updates from nrcan to support VSCode and NREL Docker images
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants