-
Notifications
You must be signed in to change notification settings - Fork 58
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Airloop naming convention change. #1856
Open
phylroy
wants to merge
18
commits into
nrcan
Choose a base branch
from
nrcan_434
base: nrcan
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
+49,423
−98,727
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Updated the HVAC system naming conventions in the NECB2011 module to include additional options for air source heat pumps with different supplemental fuels. - Modified the 'sys_htg' parameter in the system name parameters to include 'ashp>c-g' for air source heat pumps with natural gas as the supplemental fuel and 'ashp>c-e' for air source heat pumps with electricity as the supplemental fuel. - Made the necessary changes in the 'hvac_system_4.rb', 'hvac_system_1_single_speed.rb', 'hvac_systems.rb', and 'hvac_system_3_and_8_single_speed.rb' files.
Including boiler fuel type and capacity ratio changes, SHW fuel type changes, and changes from master.
Update from nrcan branch
Updates from nrcan to support VSCode and NREL Docker images
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull request overview
Pull Request Author
bundle exec rake doc
)bundle exec rake rubocop
)require
statements, ensure these are in core ruby or add to the gemspecReview Checklist
This will not be exhaustively relevant to every PR.