-
Notifications
You must be signed in to change notification settings - Fork 172
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[BUGFIX] AWC wake mixing factor with mixed awc_modes inputs #1090
base: develop
Are you sure you want to change the base?
Conversation
@misi9170 These changes fix the issue with AWC in the cases I'm testing. However, I'm not sure I fully understand the shape of the numpy arrays |
@gyalla , totally fair, yes I'll take a look now |
@gyalla , your proposal looks good to me. I've reformatted it a little bit, but all works fine. I was going to add another test to ensure that checks this functionality, but I realized we don't yet have a place where we test how the operation models affect flows, so to speak---I'll open an issue for that (#1091 ), but likely that'll happen at a later date. Thanks again for providing an example runscript in #1089---that's really helpful. |
Thanks for taking a look @misi9170, and for reformatting the code. All looks good to me, so feel free to merge whenever makes sense. |
Making a note here that this change means that if any entries in |
@misi9170, we need to specify the mixing factor as
Otherwise, if |
Good catch @gyalla ! Actually, I was just talking to @rafmudaf about exactly this type of thing, and what we should really be using is the |
This PR addresses a bug in the mixing factor when using AWC that was identified in issue #1089.