Model Fit v2 #213
Closed
Model Fit v2 #213
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Model Fit v2
This pull replaces rebuilds and replaces #206, by starting off the flasc-dataframe branch and connects to the reworked parrerlization branch of FLORIS: https://github.com/NREL/floris/tree/parallel-model-rework. This will need to be updated as those branches are finalized but this provides the cleanest starting position for this PR.
This PR adds the newly modularized
ModelFitclass for generic tuning of FLORIS models to FlascDataframes.TODO: Update this PR as progress is made on this, or the underlying
FlascDataframepr: #212 , or https://github.com/NREL/floris/tree/parallel-model-reworkFeature or improvement description
Replaces #206