-
Notifications
You must be signed in to change notification settings - Fork 36
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Opendss writer: add unbalanced loads #408
base: master
Are you sure you want to change the base?
Conversation
@tarekelgindy review this after #401 is merged (o.w. unnecessary changes show up in this PR) |
…ditto into opendss-unbal-loads
|
||
# positions (Not mapped) | ||
|
||
for phase_load in i.phase_loads: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hmmm isn't the section below potentially duplicating the changes made above to txt? Should the section below be removed?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This section already existed and it only applies to ZIP load models. It has been awhile but I think I just left this here because I was not sure where it should go. I have not used the ZIP model in OpenDSS. Are you familiar with how we should parse it for unbalanced loads? Maybe the if
can be part of the for phase_load in i.phase_loads
above on line 1967
txt += " kvar={Q}".format(Q=kvars[n]) | ||
|
||
txt += vmin_txt | ||
txt += vmax_txt |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
See comment above. I think some aspects of the original mapping might not be included here. Is that intentional?
I think that this could be restructured to include duplication with the balanced section.
currently the opendss writer sums up all phase loads to place them on a bus (which implies that loads are balanced equally on each phase at each bus):
ditto/ditto/writers/opendss/write.py
Lines 1887 to 1890 in 8d0d7a5
this PR allows for defining individual phase loads by creating
New Load
for eachPhaseLoad
.