Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Opendss unittests #215

Open
wants to merge 26 commits into
base: master
Choose a base branch
from
Open

Opendss unittests #215

wants to merge 26 commits into from

Conversation

kavuribhavya
Copy link
Collaborator

These are the initial unit tests, they are not fully completed but having them here for reference.

@kavuribhavya kavuribhavya changed the title Open dss unittests Opendss unittests Oct 23, 2018
@kavuribhavya kavuribhavya added testingupdates Issues discovered during unit testing Do Not Merge labels Oct 23, 2018
@codecov-io
Copy link

codecov-io commented Oct 23, 2018

Codecov Report

Merging #215 into master will increase coverage by 2.31%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #215      +/-   ##
==========================================
+ Coverage   43.92%   46.24%   +2.31%     
==========================================
  Files          75       75              
  Lines       17036    19009    +1973     
==========================================
+ Hits         7483     8790    +1307     
- Misses       9553    10219     +666
Impacted Files Coverage Δ
ditto/readers/json/read.py 86.53% <0%> (-2.01%) ⬇️
ditto/readers/synergi/read.py 3.16% <0%> (-1.58%) ⬇️
ditto/writers/ephasor/write.py 89.39% <0%> (-1.03%) ⬇️
ditto/readers/opendss/read.py 62.07% <0%> (+1.06%) ⬆️
ditto/writers/json/write.py 95.07% <0%> (+1.88%) ⬆️
ditto/readers/cyme/read.py 63.38% <0%> (+2.19%) ⬆️
ditto/readers/abstract_reader.py 59.75% <0%> (+3.65%) ⬆️
ditto/writers/opendss/write.py 66.62% <0%> (+4.32%) ⬆️
ditto/readers/gridlabd/read.py 61.43% <0%> (+5.88%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update cbbe27c...672dd46. Read the comment docs.

@NicolasGensollen
Copy link
Member

We need to solve #210 #211 #213 and #214 which were raised by this PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Do Not Merge testingupdates Issues discovered during unit testing
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants