Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix/grade checks #80

Open
wants to merge 11 commits into
base: main
Choose a base branch
from
Open

Fix/grade checks #80

wants to merge 11 commits into from

Conversation

calbaker
Copy link
Contributor

@calbaker calbaker commented Jun 28, 2024

checks that max absolute grade does not exceed 5%

tasks

  • Per Garrett, the link index in which offending grades are detected is printed with the wrong value.
  • Grade exceeds 5% in some places that needs to be addressed
  • currently, grade checks can be disabled in links, but there are enough egregious violations in the Taconite and other networks that we need a coarser way of disabling grade checks at the network level or similar

@calbaker calbaker requested a review from mbbruch June 28, 2024 19:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant