Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fuel Cell Cash Flow #1995

Merged
merged 2 commits into from
Jan 28, 2025
Merged

Fuel Cell Cash Flow #1995

merged 2 commits into from
Jan 28, 2025

Conversation

cpaulgilman
Copy link
Collaborator

Pull Request Template

  • Add missing fuel cell fuel O&M cost line item to cash flow.
  • Fix broken Send-to-Excel with Equations for Fuel Cell / Commercial configuration that caused callback script error about missing Excel named range.

Fixes #1975

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update
  • This change modifies variables in existing compute modules. Please see Checking for PySAM Incompatible API Changes.
  • This change requires updating the PySAM files via export_config. Please see When do the PySAM files need to be regenerated?

Checklist:

If you have added a new compute module in a SSC pull request related to this one, be sure to check the Process Requirements.

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules
  • I have checked my code and corrected any misspellings

@cpaulgilman cpaulgilman added this to the 2024 Release Patch 1 milestone Jan 23, 2025
@cpaulgilman cpaulgilman requested a review from brtietz January 23, 2025 17:36
@cpaulgilman cpaulgilman self-assigned this Jan 23, 2025
Copy link
Collaborator

@brtietz brtietz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for fixing!

@cpaulgilman cpaulgilman merged commit 56b83b6 into patch Jan 28, 2025
8 checks passed
@cpaulgilman cpaulgilman deleted the sam-1975-fuel-cell-cash-flow branch January 28, 2025 15:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fuel cell fuel costs are not a line item in the cash flow
2 participants