Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set reopt_version in response meta data programmatically #593

Merged
merged 16 commits into from
Jul 22, 2024

Conversation

hdunham
Copy link
Collaborator

@hdunham hdunham commented Jul 10, 2024

Please check if the PR fulfills these requirements

  • CHANGELOG.md is updated
  • Tests for the changes have been added (for bug fixes / features)
  • n/a Docs have been added / updated (for bug fixes / features)

What kind of change does this PR introduce?

dev process/robustness improvement

What is the current behavior?

reopt_version must be updated manually whenever REopt.jl version in environment is changed

What is the new behavior (if this is a feature change)?

reopt_version set programmatically based on actual REopt.jl package version

Does this PR introduce a breaking change?

no

Other information:

addresses issue #588

@hdunham hdunham requested a review from adfarth July 10, 2024 03:03
@hdunham hdunham linked an issue Jul 10, 2024 that may be closed by this pull request
Copy link
Collaborator

@adfarth adfarth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@hdunham this all looks great to me -- thank you for making this update!

@hdunham hdunham merged commit c3cf08f into develop Jul 22, 2024
@hdunham hdunham deleted the reoptjl-version branch July 22, 2024 20:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Make erp reopt version linked to pkg version
2 participants