Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Dc couple #435

Draft
wants to merge 74 commits into
base: develop
Choose a base branch
from
Draft

Dc couple #435

wants to merge 74 commits into from

Conversation

hdunham
Copy link
Collaborator

@hdunham hdunham commented Aug 14, 2024

No description provided.

@hdunham
add dc_coupled_with_battery option to PV model
f2025b3
@hdunham
return dc prod if dc_coupled_with_battery in call_pvwatts_api
5313e53
@hdunham
warn that PV inv_eff ignored if dc_coupled_with_electric_storage
9c8a42a
@hdunham
correct call_pvwatts_api arg issues
eb878e5
@hdunham
create dc and ac coupled tech sets
d845a9f
@hdunham
store dc_(dis)charge_efficiency in ElectricStorage
4d6fb25
@hdunham
create dvDCCoupledTechStorageInverterSize
62baad0
@hdunham
separate ac and dc coupled techs in add_elec_storage_dispatch_constra…
f6fcfc8 
…ints
@hdunham
create DV for dc coupled inverter size
7d304c8
@hdunham
don't let AC coupled elec techs charge battery (only applied if there…
c2077ee 
… are dc coupled techs)
@hdunham
Revert "don't let AC coupled elec techs charge battery (only applied …
bf9d174 
…if there are dc coupled techs)"

This reverts commit c2077ee.
@hdunham
add dc_couple_inverter_size_kw to ElectricStorage results
40f2606
@hdunham
rename to dc_coupled_with_storage
66e79f2
@hdunham
dev/debug test set up
cb26843
@hdunham
make dc coupled constraints compatible with multinode
22371c9
@hdunham
call dc coupled constraints if dc coupled tech not not empty
b6131da
@hdunham
update ac dc pv test
6c34c5e
@hdunham
(revert later and do in other branch) temp improvement to error handl…
cc9dd7b 
…ing in threaded run_reopt
@hdunham
update consrtaint on dvDCCoupledTechStorageInverterSize
3a3dd19
@hdunham
update ac dc test
79e2a9e
@hdunham
test that not letting ac coupled pv charge bess same sol as manually …
494f4d9 
…removing pv profile from load
@hdunham
don't let AC coupled techs charge bess
1bf6e71
@hdunham
adjust dc coupled dvProductionToGrid for inverter effic
4c92493
@hdunham
note PV size_kw is DC rated size when dc coupled with battery
eba969a
@hdunham
Revert "adjust dc coupled dvProductionToGrid for inverter effic"
3e1d505 
This reverts commit 4c92493.
@hdunham
reduce test atol
b36a604
@hdunham
collect DVs that can be DC on one side of load balance
7be3cc7
@hdunham
combine loops thru techs.elec in load bal
2173ab9
@hdunham
separate dc and ac coupled techs in load bal
dec927e
@hdunham
revert manually substracting pv from load (didn't fully revert c742c72 …
d85fef1 
…before)
hdunham and others added 30 commits January 12, 2024 12:38
@hdunham
readability
528f444
@hdunham
combine terms that can be DC in AnnualREEleckWh calc
7707429
@hdunham
separate dc coupled techs in AnnualREEleckWh calc and mult by inv effic
25ba6f5
@hdunham
Revert "separate dc coupled techs in AnnualREEleckWh calc and mult by…
8ec5520 
… inv effic"

This reverts commit 25ba6f5.
@hdunham
Revert "combine terms that can be DC in AnnualREEleckWh calc"
ff65789 
This reverts commit 7707429.
@hdunham
split interval constraint (not allowed)
2b0ab44
@hdunham
fix split interval constraint
e95334e
@hdunham
Revert "Revert "combine terms that can be DC in AnnualREEleckWh calc""
cfab607 
This reverts commit ff65789.
@hdunham
Revert "Revert "separate dc coupled techs in AnnualREEleckWh calc and…
8599b79 
… mult by inv effic""

This reverts commit 8ec5520.
@hdunham
handle ElectricStorage not existing in AnnualREEleckWh calc
0a5e2c4
@hdunham
test results of AnnualREEleckWh change
2dea345
@hdunham
3rd PV inputs to same as 1st (to switch dc couple keepin all else const)
5652efd
@hdunham
Revert "3rd PV inputs to same as 1st (to switch dc couple keepin all …
d054759 
…else const)"

This reverts commit 5652efd.
@hdunham
remove existing kw from dc coupled pv in test
90acd5d
@hdunham
rm info from test
1576c8f
@hdunham
Revert "remove existing kw from dc coupled pv in test"
bffb320 
This reverts commit 90acd5d.
@hdunham
Merge branch 'develop' into dc-couple
c93ce75
@hdunham
rerun debug tests
062c924
@hdunham
test rm existing PV from ac dc test - fails
8f7eb7e
@hdunham
make loads net in ac/dc test
edbed04
@hdunham
changing pv existing to min makes infeasible
4aa97f5
@hdunham
debugging infeasible
80e4929
@hdunham
remove Xpress from env and use HiGHS in debug test
20f5561
@hdunham
Merge branch 'dc-couple' of https://github.com/NREL/REopt.jl into dc-…
9c04384 
…couple
@hdunham
Update ac_dc_pvs_results.json
5d024bc
@hdunham
Merge branch 'develop' into dc-couple
6f2f226
@hdunham
uncomment dvDCCoupledTechStorageInverterSize constraints
0dcd8cd
@hdunham
comment out dvDCCoupledTechStorageInverterSize
ae497da
@hdunham
Merge branch 'develop' into dc-couple
20d6c22
@hdunham
add Logging to test Project
c383532
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@hdunham