-
Notifications
You must be signed in to change notification settings - Fork 21
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Battery storage cost constant version 2 #348
Open
toddleif
wants to merge
25
commits into
develop
Choose a base branch
from
storage-cost-constraints-version2
base: develop
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
25 commits
Select commit
Hold shift + click to select a range
53f7638
Added battery storage cost constant
toddleif 4b85f29
Fixed bugs in code and added tests
toddleif 284ec0f
Updates to test code and ran tests locally
toddleif 321e353
Updates to runtests.jl to run without battery cost constants
toddleif 7cb7460
Update to runtests.jl
toddleif 334f7cf
Updates to runtests.jl
toddleif 845e09a
Debugged financial result computation
toddleif 42732c6
update to tests with Xpress
toddleif eb60c3c
Committing again to run tests
toddleif 97173fb
Committing again to run tests
toddleif 711ce88
Merge branch 'develop' into storage-cost-constraints-version2
toddleif f5192e3
Reformulated the equations to remove the indicator constraints. Updat…
toddleif 60374c2
Added multinode capability to the battery cost constant
toddleif cb91a7e
Merge branch 'develop' into storage-cost-constraints-version2
adfarth 8e5943d
Added note for the new inputs that are not used in the battery degrad…
toddleif 1c7b658
Merge branch 'develop' into storage-cost-constraints-version2
adfarth c8c247d
Merge branch 'storage-cost-constraints-version2' of https://github.co…
toddleif 4a20641
Revert "Merge branch 'storage-cost-constraints-version2' of https://g…
toddleif a887e78
Corrected the version number
toddleif 88e25c4
Updates to the ElectricStorage cost constant code
toddleif 6594016
Merge branch 'develop' into storage-cost-constraints-version2
toddleif b6fe81d
Update CHANGELOG.md
adfarth 4138157
Edits based on code review
toddleif 7c0acf0
Merge branch 'develop' into storage-cost-constraints-version2
adfarth ba610a6
Update electric_storage.jl
adfarth File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@toddleif If I'm understanding correctly, I think the following could work for avoiding the increased run time even when a cost constant isn't included:
if p.s.storage.attr[b].installed_cost_constant != 0 || p.s.storage.attr[b].replace_cost_constant != 0
toreopt.jl
. Within that statement, add a warning about binary vars and then call "add_elec_storage_cost_constant_constraints".add_prod_incent_vars_and_constraints
as an example)