BoilerHotWater: new Off Cycle Parasitic Fuel Load field #4949
Conversation
joseph-robertson
added
Pull Request - Ready for CI
resources/model/OpenStudio.idd
Outdated
| N10; \field Off Cycle Parasitic Fuel Load | ||
| \units W | ||
| \note parasitic fuel load when the boiler is not operating (i.e., standing pilot) |
There was a problem hiding this comment.
Add required-field. And adjust \min-fields above.
Following E+ and putting it as the end. I know this is less work because no VT needed, but it's lazy. It should have been next to the On Cycle Parasitic Electric Load in E+.
Perhaps we should do it anyways.
There was a problem hiding this comment.
That was me. Yes, I was being lazy efficient.
There was a problem hiding this comment.
Can't blame you. Especially since Transition in E+ forces you to go to fortran hell :)
For us, VT will need to happen anyways to hard code it to zero, so it's two lines extra to move it in the right location
| Model m; | ||
| BoilerHotWater boiler(m); | ||
|
|
||
| ASSERT_TRUE(boiler.parasiticElectricLoad()); |
There was a problem hiding this comment.
(Side note but this should never have returned an optional)
|
Aside from the last two minor comments, this looks great! |
|
CI Results for 6f98eea:
|
Pull request overview
Boiler:HotWater.Pull Request Author
src/model/test)src/energyplus/Test)src/osversion/VersionTranslator.cpp)Labels:
IDDChangeAPIChangePull Request - Ready for CIso that CI builds your PRReview Checklist
This will not be exhaustively relevant to every PR.