Height of shading objects is incorrect

[ggartside]

Fixes 4664: floor_to_ceiling_height for Shading objects is not respected in the floorspace reverse translator

This what the model should look like

and this is what the model currently looks like

Pull request overview

• Fixes floor_to_ceiling_height for Shading objects is not respected in the floorspace reverse translator #4764

Fixes issue 4764 - Shading Floorspace objects are not converted to ShadingGroups correctly when the Shading object specifies an override for the height of the shading object

Pull Request Author

• Model API Changes / Additions
• Any new or modified fields have been implemented in the EnergyPlus ForwardTranslator (and ReverseTranslator as appropriate)
• Model API methods are tested (in src/model/test)
• EnergyPlus ForwardTranslator Tests (in src/energyplus/Test)
• If a new object or method, added a test in NREL/OpenStudio-resources: Add Link
• If needed, added VersionTranslation rules for the objects (src/osversion/VersionTranslator.cpp)
• Verified that C# bindings built fine on Windows, partial classes used as needed, etc.
• All new and existing tests passes
• If methods have been deprecated, update rest of code to use the new methods

Labels:

• If change to an IDD file, add the label IDDChange
• If breaking existing API, add the label APIChange
• If deemed ready, add label Pull Request - Ready for CI so that CI builds your PR

Review Checklist

This will not be exhaustively relevant to every PR.

• Perform a Code Review on GitHub
• Code Style, strip trailing whitespace, etc.
• All related changes have been implemented: model changes, model tests, FT changes, FT tests, VersionTranslation, OS App
• Labeling is ok
• If defect, verify by running develop branch and reproducing defect, then running PR and reproducing fix
• If feature, test running new feature, try creative ways to break it
• CI status: all green or justified

[jmarrec]

@ggartside To facilitate review, could you try to separate your changes into distinct commits, ideally in a TDD fashion (add test first, then fix, you can always rebase and reorder commits at the end)

• Add a test
• (do renames)
• fix

I have done a rebase and reauthored commits to attribute them to you this time for convenience. (I'm pushing the test now and letting CI to run so we see the failures. Then I'll push the fix part)

Also, could you post a picture showing the before/after like you did in #4764 ?

[ci-commercialbuildings]

CI Results for 707e9de:

• Ubuntu 18.04:

  • OpenStudio-3.5.1-alpha+707e9de8d6-Ubuntu-18.04.deb
  • OpenStudio-3.5.1-alpha+707e9de8d6-Ubuntu-18.04.tar.gz

• Ubuntu 20.04:

  • OpenStudio-3.5.1-alpha+707e9de8d6-Ubuntu-20.04.deb
  • OpenStudio-3.5.1-alpha+707e9de8d6-Ubuntu-20.04.tar.gz
  • perf_test/results.html

• Darwin:

  • OpenStudio-3.5.1-alpha+707e9de8d6-Darwin-x86_64.dmg
  • OpenStudio-3.5.1-alpha+707e9de8d6-Darwin-x86_64.tar.gz

• Windows:

  • OpenStudio-3.5.1-alpha+707e9de8d6-Windows.exe
  • OpenStudio-3.5.1-alpha+707e9de8d6-Windows.tar.gz

• Code Coverage: