floor_to_ceiling_height for Shading objects is not respected in the floorspace reverse translator

[ggartside]

Issue overview

The shading groups created by the floorspace reverse translator do not have the correct height

Current Behavior

A shading group is created for each shading object in the floor space json file, a collection of faces is made by extruding the 'footprint' of the shading object. The extrusion height is specified by floor_to_ceiling_height. Currently all shading groups are created with an extrusion length of 10' regardless of the value of floor_to_ceiling_height

Expected Behavior

The extrusion shape should be created with the height as specified in the floorspace json file

Steps to Reproduce

1. Generate an OSM model using the following file (can't upload a json file but it is the file referred to in Additional roof created for Floor js json import #4323 ) via the floorspace reverse translator
2. Do the same using the ThreeJS reverse translator
3. Look at shading group 1-10 (for example)

Model as generated by the ThreeJS reverse translator

Model as generated by the floorspace reverse translator

Possible Solution

Will have to correct the floorspace reverse translator code that supplies the extrusion height

Details

I have a floorspace reverse translator test that verifies this issue

Environment

Some additional details about your environment for this issue (if relevant):

• Platform (Operating system, version):
• Version of OpenStudio (if using an intermediate build, include SHA):
  latest version of develop at commit 351d37f

Context