Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Misc refactor/cleanup #1894

Merged
merged 9 commits into from
Nov 27, 2024
Merged

Misc refactor/cleanup #1894

merged 9 commits into from
Nov 27, 2024

Conversation

shorowit
Copy link
Contributor

@shorowit shorowit commented Nov 27, 2024

Pull Request Description

  • Updates HPXML::has_fuels() to traverse the HPXML object for performance reasons (particularly important when running whole SFA/MF buildings).
  • Replaces if/elsif/elsif code with case/when for code readability
  • Very minor bugfixes

No diffs expected.

Checklist

Not all may apply:

  • Schematron validator (EPvalidator.xml) has been updated
  • Sample files have been added/updated (openstudio tasks.rb update_hpxmls)
  • Tests have been added/updated (e.g., HPXMLtoOpenStudio/tests/test*.rb and/or workflow/tests/test*.rb)
  • Documentation has been updated
  • Changelog has been updated
  • openstudio tasks.rb update_measures has been run
  • No unexpected changes to simulation results of sample files

…to traverse the HPXML object for performance reasons (particularly important when running whole SFA/MF buildings).
@shorowit shorowit marked this pull request as ready for review November 27, 2024 17:32
@shorowit shorowit merged commit 1066943 into master Nov 27, 2024
@shorowit shorowit deleted the misc_refactor_cleanup branch November 27, 2024 17:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

1 participant