Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ControlType input for CFIS systems #1866

Merged
merged 4 commits into from
Oct 23, 2024
Merged

ControlType input for CFIS systems #1866

merged 4 commits into from
Oct 23, 2024

Conversation

shorowit
Copy link
Contributor

@shorowit shorowit commented Oct 23, 2024

Pull Request Description

Addresses #1029. Adds a ControlType input that can either be "optimized" (default, same as assumed before), in which ventilation operation is assumed to take advantage of normal HVAC operation as much as possible, or "timer", in which ventilation operation occurs at a fixed interval and may fully, partially, or not coincide with HVAC operation for a given hour. The latter will result in higher fan energy use.

Checklist

Not all may apply:

  • Schematron validator (EPvalidator.xml) has been updated
  • Sample files have been added/updated (openstudio tasks.rb update_hpxmls)
  • Tests have been added/updated (e.g., HPXMLtoOpenStudio/tests/test*.rb and/or workflow/tests/test*.rb)
  • Documentation has been updated
  • Changelog has been updated
  • openstudio tasks.rb update_measures has been run
  • No unexpected changes to simulation results of sample files

@shorowit shorowit added the enhancement New feature or request label Oct 23, 2024
@shorowit shorowit self-assigned this Oct 23, 2024
@shorowit shorowit marked this pull request as ready for review October 23, 2024 20:43
@shorowit shorowit merged commit 9e0f85f into master Oct 23, 2024
@shorowit shorowit deleted the cfis_control_type branch October 23, 2024 21:24
@joseph-robertson joseph-robertson mentioned this pull request Oct 25, 2024
22 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

1 participant