Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

HasOutdoorAirControl input for CFIS systems #1863

Merged
merged 15 commits into from
Oct 22, 2024
Merged

HasOutdoorAirControl input for CFIS systems #1863

merged 15 commits into from
Oct 22, 2024

Conversation

shorowit
Copy link
Contributor

@shorowit shorowit commented Oct 17, 2024

Pull Request Description

Addresses #1029. Allows specifying that a CFIS system does not have outdoor air control, such that when the HVAC system is operating, outdoor air is always being brought in. Defaults to assuming there is outdoor air control.

Checklist

Not all may apply:

  • Schematron validator (EPvalidator.xml) has been updated
  • Sample files have been added/updated (openstudio tasks.rb update_hpxmls)
  • Tests have been added/updated (e.g., HPXMLtoOpenStudio/tests/test*.rb and/or workflow/tests/test*.rb)
  • Documentation has been updated
  • Changelog has been updated
  • openstudio tasks.rb update_measures has been run
  • No unexpected changes to simulation results of sample files

@shorowit shorowit added the enhancement New feature or request label Oct 17, 2024
@shorowit shorowit self-assigned this Oct 17, 2024
@shorowit shorowit changed the title HasOutdoorAirControl input or CFIS systems HasOutdoorAirControl input for CFIS systems Oct 17, 2024
@shorowit shorowit marked this pull request as ready for review October 22, 2024 16:48
@shorowit shorowit merged commit 9332bad into master Oct 22, 2024
7 checks passed
@shorowit shorowit deleted the cfis_oa_control branch October 22, 2024 16:48
@joseph-robertson joseph-robertson mentioned this pull request Oct 23, 2024
22 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

1 participant