Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add schedule methods to model.rb #1851

Merged
merged 12 commits into from
Oct 5, 2024
Merged

Add schedule methods to model.rb #1851

merged 12 commits into from
Oct 5, 2024

Conversation

shorowit
Copy link
Contributor

@shorowit shorowit commented Oct 5, 2024 •
edited
Loading

Pull Request Description

[description here]

Checklist

Not all may apply:

  • Schematron validator (EPvalidator.xml) has been updated
  • Sample files have been added/updated (openstudio tasks.rb update_hpxmls)
  • Tests have been added/updated (e.g., HPXMLtoOpenStudio/tests/test*.rb and/or workflow/tests/test*.rb)
  • Documentation has been updated
  • Changelog has been updated
  • openstudio tasks.rb update_measures has been run
  • No unexpected changes to simulation results of sample files

@shorowit shorowit self-assigned this Oct 5, 2024
@shorowit shorowit marked this pull request as ready for review October 5, 2024 19:52
@shorowit shorowit merged commit afdd388 into master Oct 5, 2024
@shorowit shorowit deleted the schedule_methods branch October 5, 2024 19:52
@joseph-robertson joseph-robertson mentioned this pull request Oct 7, 2024
Merged
22 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@shorowit shorowit

Labels
refactor
Projects
OpenStudio-HPXML
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@shorowit