Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Avoid CSV library for speed #1844

Merged
merged 3 commits into from
Sep 26, 2024
Merged

Avoid CSV library for speed #1844

merged 3 commits into from
Sep 26, 2024

Conversation

shorowit
Copy link
Contributor

@shorowit shorowit commented Sep 26, 2024

Pull Request Description

Speeds up reading/writing/processing detailed schedule files and writing CSV timeseries output by avoiding the CSV library. It's fine to use for smaller files, but much slower for larger files.

This will be most impactful for a whole MF building simulation where each unit has detailed schedules.

Checklist

Not all may apply:

  • Schematron validator (EPvalidator.xml) has been updated
  • Sample files have been added/updated (openstudio tasks.rb update_hpxmls)
  • Tests have been added/updated (e.g., HPXMLtoOpenStudio/tests/test*.rb and/or workflow/tests/test*.rb)
  • Documentation has been updated
  • Changelog has been updated
  • openstudio tasks.rb update_measures has been run
  • No unexpected changes to simulation results of sample files

@shorowit shorowit self-assigned this Sep 26, 2024
@shorowit shorowit merged commit 69b9cb7 into master Sep 26, 2024
@shorowit shorowit deleted the avoid_csv_library branch September 26, 2024 06:06
@joseph-robertson joseph-robertson mentioned this pull request Sep 26, 2024
26 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

1 participant