Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update default for HVACSizingControl/ManualJInputs/NumberofOccupants #1842

Merged
merged 2 commits into from
Sep 24, 2024
Merged

Update default for HVACSizingControl/ManualJInputs/NumberofOccupants #1842

merged 2 commits into from
Sep 24, 2024

Conversation

shorowit
Copy link
Contributor

@shorowit shorowit commented Sep 24, 2024 •
edited
Loading

Pull Request Description

Fixes #1841.

Checklist

Not all may apply:

  • Schematron validator (EPvalidator.xml) has been updated
  • Sample files have been added/updated (openstudio tasks.rb update_hpxmls)
  • Tests have been added/updated (e.g., HPXMLtoOpenStudio/tests/test*.rb and/or workflow/tests/test*.rb)
  • Documentation has been updated
  • Changelog has been updated
  • openstudio tasks.rb update_measures has been run
  • No unexpected changes to simulation results of sample files

@shorowit shorowit self-assigned this Sep 24, 2024
joseph-robertson
joseph-robertson approved these changes Sep 24, 2024
View reviewed changes
Copy link
Collaborator

@joseph-robertson joseph-robertson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Worth a Changelog.md entry? If not, good to merge.

workflow/tests/base_results/results_simulations_hvac.csv Show resolved Hide resolved
@shorowit
Copy link
Contributor Author

Worth a Changelog.md entry? If not, good to merge.

I figured it can be part of misc improvements.

@shorowit shorowit merged commit 990df15 into master Sep 24, 2024
@shorowit shorowit deleted the mj_default_num_occupants branch September 24, 2024 23:40
@joseph-robertson joseph-robertson mentioned this pull request Sep 25, 2024
Merged
26 tasks
@shorowit shorowit mentioned this pull request Sep 25, 2024
Merged
7 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@joseph-robertson joseph-robertson joseph-robertson approved these changes

Assignees

@shorowit shorowit

Labels
None yet
Projects
OpenStudio-HPXML
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Update default for HVACSizingControl/ManualJInputs/NumberofOccupants
2 participants
@shorowit @joseph-robertson