Skip to content

Commit

Permalink
Add sample file for detailed panel upgrade.
Browse files Browse the repository at this point in the history
  • Loading branch information
joseph-robertson committed Oct 21, 2024
1 parent e01723f commit 2bbcc38
Show file tree
Hide file tree
Showing 4 changed files with 626 additions and 6 deletions.
6 changes: 3 additions & 3 deletions HPXMLtoOpenStudio/measure.xml
Original file line number Diff line number Diff line change
Expand Up @@ -3,8 +3,8 @@
<schema_version>3.1</schema_version>
<name>hpxm_lto_openstudio</name>
<uid>b1543b30-9465-45ff-ba04-1d1f85e763bc</uid>
<version_id>623db81b-5061-420a-960f-8d33a1ed0aa5</version_id>
<version_modified>2024-10-21T17:55:08Z</version_modified>
<version_id>d4204431-8a89-43a5-84d2-55a89309869f</version_id>
<version_modified>2024-10-21T19:45:04Z</version_modified>
<xml_checksum>D8922A73</xml_checksum>
<class_name>HPXMLtoOpenStudio</class_name>
<display_name>HPXML to OpenStudio Translator</display_name>
Expand Down Expand Up @@ -327,7 +327,7 @@
<filename>defaults.rb</filename>
<filetype>rb</filetype>
<usage_type>resource</usage_type>
<checksum>60D12E27</checksum>
<checksum>2F35F039</checksum>
</file>
<file>
<filename>electric_panel.rb</filename>
Expand Down
6 changes: 3 additions & 3 deletions HPXMLtoOpenStudio/resources/defaults.rb
Original file line number Diff line number Diff line change
Expand Up @@ -3264,6 +3264,7 @@ def self.apply_electric_panels(hpxml_bldg, unit_num)
ventilation_fan_ids = []
hpxml_bldg.ventilation_fans.each do |ventilation_fan|
next if !ventilation_fan.panel_loads.nil?
next if ![HPXML::LocationKitchen, HPXML::LocationBath].include?(ventilation_fan.fan_location)

ventilation_fan_ids << ventilation_fan.id
end
Expand All @@ -3273,7 +3274,7 @@ def self.apply_electric_panels(hpxml_bldg, unit_num)
end

if panel_loads.count { |pl| pl.type == HPXML::ElectricPanelLoadTypeOther && pl.system_idrefs.empty? } == 0
panel_loads.add(type: HPXML::ElectricPanelLoadTypeOther) # for garbage disposal and garage door opener
panel_loads.add(type: HPXML::ElectricPanelLoadTypeOther, system_idrefs: []) # for garbage disposal and garage door opener
end
if panel_loads.count { |pl| pl.type == HPXML::ElectricPanelLoadTypeLighting } == 0
electric_panel.panel_loads.add(type: HPXML::ElectricPanelLoadTypeLighting)
Expand All @@ -3291,7 +3292,6 @@ def self.apply_electric_panels(hpxml_bldg, unit_num)
panel_load.voltage_isdefaulted = true
end
if panel_load.watts.nil?
puts "#{panel_load.type} #{panel_load.system_idrefs}"
panel_load.watts = get_panel_load_watts_default_values(hpxml_bldg, panel_load.type, panel_load.voltage, panel_load.system_idrefs)
panel_load.watts_isdefaulted = true
end
Expand Down Expand Up @@ -5941,7 +5941,7 @@ def self.get_panel_load_watts_default_values(hpxml_bldg, type, voltage, system_i
elsif type == HPXML::ElectricPanelLoadTypeLaundry
return 1500
elsif type == HPXML::ElectricPanelLoadTypeOther
if system_ids.nil? || system_ids.empty?
if system_ids.empty?
watts += 559 # Garbage disposal

if hpxml_bldg.has_location(HPXML::LocationGarage)
Expand Down
20 changes: 20 additions & 0 deletions workflow/hpxml_inputs.json
Original file line number Diff line number Diff line change
Expand Up @@ -1625,6 +1625,26 @@
"cooling_system_panel_load_breaker_spaces": 2,
"cooling_system_panel_load_addition": false
},
"sample_files/base-detailed-electric-panel-upgrade.xml": {
"parent_hpxml": "sample_files/base-detailed-electric-panel.xml",
"heating_system_type": "none",
"cooling_system_type": "none",
"heat_pump_type": "air-to-air",
"heat_pump_heating_efficiency": 7.7,
"heat_pump_cooling_efficiency": 13,
"heat_pump_heating_capacity": 52280,
"heat_pump_cooling_capacity": 52280,
"heat_pump_backup_type": "integrated",
"heat_pump_backup_heating_efficiency": 1,
"heat_pump_backup_heating_capacity": 27960,
"heat_pump_panel_load_watts": 17943,
"heat_pump_panel_load_addition": true,
"water_heater_fuel_type": "electricity",
"cooking_range_oven_fuel_type": "electricity",
"clothes_dryer_fuel_type": "electricity",
"misc_plug_loads_vehicle_present": true,
"electric_panel_num_breaker_spaces": 7
},
"sample_files/base-enclosure-2stories.xml": {
"parent_hpxml": "sample_files/base.xml",
"geometry_unit_num_floors_above_grade": 2,
Expand Down
Loading

0 comments on commit 2bbcc38

Please sign in to comment.