Skip to content

Commit

Permalink
Here VRFRTF is not initialized, don't multiply here to defrost
Browse files Browse the repository at this point in the history
  • Loading branch information
Yujie Xu committed Sep 20, 2024
1 parent 5556102 commit d08b956
Showing 1 changed file with 0 additions and 1 deletion.
1 change: 0 additions & 1 deletion src/EnergyPlus/HVACVariableRefrigerantFlow.cc
View file
Original file line number Diff line number Diff line change
Expand Up @@ -908,7 +908,6 @@ void CalcVRFCondenser(EnergyPlusData &state, int const VRFCond)
}
}
}
vrf.DefrostPower *= VRFRTF;

This comment has been minimized.

Sign in to view

Copy link
@rraustad

rraustad Sep 20, 2024

Contributor

When I saw this I looked and see this is just after the defrost model calcs. So yes, this does not belong here because RTF has not yet been calculated. Then I looked to where defrost power does get updated by RTF. It's at the end of this IF block at line 1159:

if (state.dataHVACVarRefFlow->HeatingLoad(VRFCond) && HeatingPLR > 0.0) {

so here's my question. If outdoor conditions cause a non-zero defrost power, AND the system if off, does the defrost power still report as non-zero? It looks like it would. If so, then move line 1197 down 2 lines outside the IF block.

Image

TotalCondHeatingCapacity =
vrf.HeatingCapacity * state.dataHVACVarRefFlow->HeatCombinationRatio(VRFCond) * TotHeatCapTempModFac * HeatingCapacityMultiplier;
Expand Down

1 comment on commit d08b956

@nrel-bot
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fixVRFhighCOP (Unknown) - Win64-Windows-10-VisualStudio-16: Tests Failed (0 of 0 tests passed, 0 test warnings)

Build Badge Test Badge

Please sign in to comment.