Skip to content

Commit

Permalink
fix errors in VRP calculations for zone design terms for secondary re…
Browse files Browse the repository at this point in the history 
…circulation systems
  • Loading branch information
@EnergyArchmage
EnergyArchmage committed Sep 30, 2024
1 parent b422061 commit 46ef789
Showing 1 changed file with 7 additions and 7 deletions.
14 changes: 7 additions & 7 deletions src/EnergyPlus/SizingManager.cc
View file
Original file line number Diff line number Diff line change
Expand Up @@ -1341,23 +1341,23 @@ void ManageSystemVentilationAdjustments(EnergyPlusData &state)
Real64 Ez_Clg = thisTermUnitFinalZoneSizing.ZoneADEffCooling; // user input in Zone Air Distribution design spec object
Real64 Fc_Clg = 1.0 - (1.0 - Ez_Clg) * (1.0 - Er) * (1 - Ep_Clg);
state.dataSize->FcByZoneCool(termUnitSizingIndex) = Fc_Clg;
state.dataSize->EvzByZoneCool(termUnitSizingIndex) =
(Fa_Clg + state.dataSize->XsBySysCool(AirLoopNum) * Fb_Clg - state.dataSize->ZdzClgByZone(termUnitSizingIndex) * Fc_Clg) /
Fa_Clg;
state.dataSize->EvzByZoneCool(termUnitSizingIndex) = (Fa_Clg + state.dataSize->XsBySysCool(AirLoopNum) * Fb_Clg -
state.dataSize->ZdzClgByZone(termUnitSizingIndex) * Ep_Clg * Fc_Clg) /
Fa_Clg;
// note that SimAirServingZones::LimitZoneVentEff is intended only for single path per I/O ref

// find Evz for heating
Real64 Ep_Htg = thisTermUnitFinalZoneSizing.ZonePrimaryAirFractionHtg; // as adjusted in ManageSystemSizingAdjustments();
Real64 Fa_Htg = Ep_Htg + (1.0 - Ep_Htg) * Er;
state.dataSize->FaByZoneHeat(termUnitSizingIndex) = Fa_Htg;
Real64 Fb_Htg = Ep_Htg;
state.dataSize->FbByZoneCool(termUnitSizingIndex) = Fb_Htg;
state.dataSize->FbByZoneHeat(termUnitSizingIndex) = Fb_Htg;
Real64 Ez_Htg = thisTermUnitFinalZoneSizing.ZoneADEffHeating; // user input in Zone Air Distribution design spec object
Real64 Fc_Htg = 1.0 - (1.0 - Ez_Htg) * (1.0 - Er) * (1 - Ep_Htg);
state.dataSize->FcByZoneHeat(termUnitSizingIndex) = Fc_Htg;
state.dataSize->EvzByZoneHeat(termUnitSizingIndex) =
(Fa_Htg + state.dataSize->XsBySysHeat(AirLoopNum) * Fb_Htg - state.dataSize->ZdzHtgByZone(termUnitSizingIndex) * Fc_Htg) /
Fa_Htg;
state.dataSize->EvzByZoneHeat(termUnitSizingIndex) = (Fa_Htg + state.dataSize->XsBySysHeat(AirLoopNum) * Fb_Htg -
state.dataSize->ZdzHtgByZone(termUnitSizingIndex) * Ep_Htg * Fc_Htg) /
Fa_Htg;

} else { // 62.1 ventilation rate procedure - single path zone
state.dataSize->EvzByZoneCool(termUnitSizingIndex) =
Expand Down

4 comments on commit 46ef789

@nrel-bot-2c
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

10774-std-62-1-errors (EnergyArchmage) - x86_64-Linux-Ubuntu-22.04-gcc-11.4: OK (2914 of 2914 tests passed, 0 test warnings)

Build Badge Test Badge

@nrel-bot
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

10774-std-62-1-errors (EnergyArchmage) - Win64-Windows-10-VisualStudio-16: OK (2892 of 2892 tests passed, 0 test warnings)

Build Badge Test Badge

@nrel-bot-2c
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

10774-std-62-1-errors (EnergyArchmage) - x86_64-Linux-Ubuntu-22.04-gcc-11.4-UnitTestsCoverage-RelWithDebInfo: OK (2098 of 2098 tests passed, 0 test warnings)

Build Badge Test Badge Coverage Badge

@nrel-bot-2
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

10774-std-62-1-errors (EnergyArchmage) - x86_64-Linux-Ubuntu-22.04-gcc-11.4-IntegrationCoverage-RelWithDebInfo: OK (799 of 799 tests passed, 0 test warnings)

Build Badge Test Badge Coverage Badge

Please sign in to comment.