-
Notifications
You must be signed in to change notification settings - Fork 137
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Makes MAX_FIELDS_PER_FILE a namelist variable and allocates #750
base: main
Are you sure you want to change the base?
Conversation
…s with this value.
@menzel-gfdl can you test this? Does it fulfill your request? |
@menzel-gfdl do you still want this? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If this change goes through, the error message in diag_manager/diag_util.F90 at line 1356ff needs to be updated.
@thomas-robinson sorry I've been distracted by a lot of other projects. What are your thoughts? I proposed this because we kind of need 5d diagnostics (time, z, lat, lon, spectral dimension). Right now our only option is to create one variable per spectral dimension (band, wavenumber, gpoint, etc.), which as you can imagine leads to a very high number of diagnostics. Is there a better solution? |
@menzel-gfdl Yes there is a plan to support more dimensions in the diag manager rewrite. Although the target is September, there is no guarantee that 5D support will be working by then. If this PR solves your problem more immediately, then why not take it now. I don't think there is a reason why this shouldn't be done. |
Description
Changes the
max_fields_per_file
to a namelist variable, and allocated thefields
with this value.Fixes #747
How Has This Been Tested?
make
run with intelChecklist:
make distcheck
passes