more namelist cleanfile - (drifters, fft, field_manager, horiz_interp) #170
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
edwardhartnett
commented
Sep 20, 2019
edwardhartnett
changed the title
|
BTW we have seen some intermittent travis failures here which are pretty normal. One build failed because the install of the software timed out. Another time, Travis just got stuck, reporting the build as still running (yellow) but when you click through, the build had succeeded and exited, however travis does not notice the success. These are normal with Travis. It's not perfect! But it's still great. Developers can restart the tests by checking in more changes on the branch (as I just did). Admins can also restart tests on their travis dashboard without changes being needed. |
|
OK, great! Now Travis is happy and I'm happy with these 4 directories. ;-) @underwoo take a look at your convenience. I will do more directories on a separate PR... |
underwoo
approved these changes
Sep 22, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of #160
This PR includes PR #164 which has been reviewed and approved already (the changes to the axis_util directory to fix the namelist cleanfile problems).
In this PR I have applied these changes to the drifter and fft directories. At this point I stopped because I am not sure what is going on. The fft directory test uses an input.nml, but the file is already called input_base.nml, so what is the program using? (This could be failing in your tests but not be noticed by travis. See #169.