Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature branch/data quality #6473

Open
wants to merge 51 commits into
base: main
Choose a base branch
from
Open

Feature branch/data quality #6473

wants to merge 51 commits into from

Conversation

duncanc19
Copy link
Collaborator

Work done

Tests

Does this PR include tests for the changes introduced?

  • Yes
  • No, I found it difficult to test
  • No, they are not required for this change

kapppa-joe and others added 30 commits December 24, 2024 13:24
@kapppa-joe
start adding delete-staff-record component
271ed96
@kapppa-joe
add confirm and cancel buttons
44356e7
@kapppa-joe
implement validation and error msg
52bd07b
@kapppa-joe
add call to deleteWorker
dc38c57
@kapppa-joe
adding a textbox for other reason
dafcfa5
@kapppa-joe
add unit test for other reason textbox
9047a9f
@kapppa-joe
add unit tests related to other leave reason and additional details text
b25abac
@kapppa-joe
add a migration to change the text for worker leave reasons
23bd3a0
@kapppa-joe
update the link of delete staff record button to new page
6459121
@kapppa-joe
add character count to page
f438ca6
@kapppa-joe
bugfix and refactoring for CharacterCount component
4dbdacb
@kapppa-joe
correct wrong path name in routing table and link
9980ab8
@kapppa-joe
amend character counts to be able to work with {updateOn: submit}
face38a
@kapppa-joe
refactoring
b8e6e1f
@ssrome
Add workplace name address component
ad932ab
@kapppa-joe
adjust css
ec2aa4c
@kapppa-joe
delete the old delete-worker-dialog component
3cc9f71
@kapppa-joe
update alert message
a985081
@kapppa-joe
add scroll to error summary
ddfcecb
@kapppa-joe
text update
7cccd12
@kapppa-joe
minor fix
f52010f
@duncanc19
Create new column on login table for lastViewedSLVMessage and add to …
829c59d 
…login response
@duncanc19
Create page with content and Continue button which goes to dashboard
807587e
@duncanc19
Refactor login component spec file to use overrides
5b39bce
@duncanc19
Update login spec tests to trigger user events rather than set form s…
b3cbd4c 
…tate directly
@duncanc19
Add tests around navigation after login and refactor
a68d51f
@duncanc19
Navigate to new page when edit user and lastViewedSLVMessage in respo…
1b2f943 
…nse is falsy
@duncanc19
Add check for date last viewed message being over six months
ddc7cbd
@duncanc19
Add test for higher priority navigation
c3f2e58
@duncanc19
Add check for workplace being data owner to navigate to SLV message page
297d725
duncanc19 and others added 20 commits January 8, 2025 14:26
@duncanc19
Set up call to user service from message page (with backend call stub…
3fc182c 
…bed)
@duncanc19
Update PR to add new logic to User table to pass data from user more …
679abce 
…easily than login table
@duncanc19
Update login component to handle conversion of date from DB for last …
c16aa9f 
…viewed date
@ssrome
Add parent link and workplace address to dashboard header
c337729
@ssrome
Add test file
eaea502
@duncanc19
Update content of message page
fa3247c
@duncanc19
Rename component and function in user service
a5241ae
@ssrome
Add return to url and update styles
c1e7e12
@ssrome
Change layout of workplace summary
00bc759
@ssrome
Merge branch 'main' into feat/1586-dq-workplace-restructure
4f90314
@duncanc19
Update spacing on message page
ebe4233
@duncanc19
Rename new User table column and backend code to make more descriptive
065f562
@ssrome
Refactor test to pass workplace
35b04db
@ssrome
Update variable on test
a90672b
@duncanc19
Move backend call into onInit to ensure only called once
ccf5b49
@duncanc19
Add send to updateLastViewedVacanciesAndTurnoverMessage to stop endpo…
80e3cae 
…int response timing out
@duncanc19
Use uuid package instead of own uid validation
5989fc2
@duncanc19
Merge pull request #6469 from NMDSdevopsServiceAdm/feat/1589-data-qua…
1333c67 
…lity-log-in-message

Feat/1589 data quality log in message
@ssrome
Merge pull request #6471 from NMDSdevopsServiceAdm/feat/1586-dq-workp…
30afc49 
…lace-restructure

Feat/1586 dq workplace restructure
@kapppa-joe
Merge pull request #6468 from NMDSdevopsServiceAdm/feat/1587-dq-reaso…
aec1e18 
…n-for-leave-page

Feat/1587 dq reason for leave page
accesslint[bot]
accesslint bot reviewed Jan 13, 2025
View reviewed changes
Copy link

@accesslint accesslint bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There are accessibility issues in these changes.

frontend/src/app/features/workers/delete-staff-record/delete-staff-record.component.html Show resolved Hide resolved
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@accesslint accesslint[bot] accesslint[bot] left review comments

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@duncanc19 @kapppa-joe @ssrome