Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature branch/forgotten username #6466

Merged
merged 100 commits into from
Jan 7, 2025
Merged

Feature branch/forgotten username #6466

merged 100 commits into from
Jan 7, 2025

Conversation

duncanc19
Copy link
Collaborator

kapppa-joe and others added 30 commits December 3, 2024 14:24
@kapppa-joe
add forgot-your-username-or-password component
b7a5c85
@kapppa-joe
start adding validation
0c4156b
@kapppa-joe
add unit tests for navigation
36fee5f
@kapppa-joe
adjust css
f889982
@kapppa-joe
amend forgot-your-password component
f92cbb0
@kapppa-joe
amend error message retrieval
83a9d76
@kapppa-joe
adjust css
d97fd6a
@kapppa-joe
adjust css
127aefd
@kapppa-joe
fix an issue about unit test config
fb4f238
@kapppa-joe
sort import
0b53bcb
@kapppa-joe
update test content and css
dc1c277
@kapppa-joe
update confirmation screen message
65be38a
@kapppa-joe
add nowrap class to tel number
f0c4baa
@ssrome
Add validation check for at signs in username
c5fc166
@ssrome
Add password toggle and showadditional error message
53c8e24
@kapppa-joe
Merge pull request #6443 from NMDSdevopsServiceAdm/feat/1569-new-page…
d38ad7f 
…-after-clicking-link

Feat/1569 new page after clicking link
@ssrome
Merge branch 'feature-branch/forgotten-username' into feat/1567-forgo…
effa545 
…tten-username-changes-to-log-in-page
@ssrome
Create new page to display username
d546629
@ssrome
Remove unused regex
fed95ed
@ssrome
Update test names
545e7c9
@ssrome
Merge pull request #6446 from NMDSdevopsServiceAdm/feat/1567-forgotte…
cfc3af2 
…n-username-changes-to-log-in-page

Feat/1567 forgotten username changes to log in page
@ssrome
Add panel to display
9e946b6
@kapppa-joe
amend folder structure, add forgot-your-username component
e219b66
@kapppa-joe
add find-account child component
d5372fb
@kapppa-joe
implement submit and validation logic for findAccount form
aea6c7b
@kapppa-joe
amend the handling of findUserAccount response
c5fa77d
@kapppa-joe
implement POST: findUserAccount endpoint
dde9a60
@kapppa-joe
fix .padEnd call at backend
1e32365
@kapppa-joe
emit account uid & question to parent component, add scrolling
d61921c
@kapppa-joe
add aria-live to result div for accessibility
870438c
kapppa-joe and others added 27 commits December 23, 2024 14:30
@kapppa-joe
minor fix, replace hardcoded string "Locked" with shared constant
7a2071d
@kapppa-joe
refactor findUsername
6eeca73
@kapppa-joe
fix incorrect field name
bdcb067
@kapppa-joe
minor amend
325b030
@kapppa-joe
use 429 Too many request instead of 423 Locked when findAccount reach…
4ec1210 
…ed maximum retry limit
@kapppa-joe
modifying findUsername service to handle the case when account is locked
c6cc5cc
@kapppa-joe
amend findUserAccount endpoint to represent different cases by status…
afcf9d9 
… code
@kapppa-joe
handle the case of AccountLocked at findAccount
17a8db2
@kapppa-joe
remove f from describe block
2613401
@kapppa-joe
adjust css
ec67ad7
@kapppa-joe
update heading texts
938d315
@kapppa-joe
update error message text
d98ddf9
@kapppa-joe
text updates
3017bfd
@kapppa-joe
change the error message for account locked case as non-clickable text
c451a29
@kapppa-joe
css adjustment (no underline for account locked error message)
1444159
@kapppa-joe
replace hardcoded value with constant
4b7ee0c
@kapppa-joe
fix unit test
eb32a34
@kapppa-joe
Merge pull request #6459 from NMDSdevopsServiceAdm/feat/1570-forgot-u…
1b420bc 
…sername-limit-attempt

Feat/1570 forgot username limit attempt
@kapppa-joe
try fix redis client config for find user account attempts
3b42e8b
@kapppa-joe
Merge pull request #6460 from NMDSdevopsServiceAdm/fix/redis-config-f…
550e46c 
…or-find-user-account-attempts

try fix redis client config for find user account attempts
@kapppa-joe
on user account not found, give a 200 response with status: AccountNo…
36a8c77 
…tFound instead of 404 response
@kapppa-joe
Merge pull request #6461 from NMDSdevopsServiceAdm/fix/use-200-instea…
e0fbf6a 
…d-of-404-on-account-not-found

on user account not found, give a 200 response with status: AccountNo…
@kapppa-joe
handle the case for multiple accounts found in FindUserAccount
8990db2
@kapppa-joe
minor amend
46b9315
@kapppa-joe
Merge pull request #6463 from NMDSdevopsServiceAdm/fix/1588-multiple-…
b9dc866 
…accounts-found

Fix/1588 multiple accounts found
@kapppa-joe
when error message of invalid username/password is clicked, set focus…
a5794c8 
… on the username input box
@kapppa-joe
Merge pull request #6465 from NMDSdevopsServiceAdm/fix/login-page-set…
9fc243f 
…-focus-on-username-field

Fix/Login page - should set focus on username field when invalid username/password error message is clicked
@kapppa-joe kapppa-joe merged commit 3cfd4ef into main Jan 7, 2025
5 checks passed
@kapppa-joe kapppa-joe deleted the feature-branch/forgotten-username branch January 7, 2025 14:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kapppa-joe kapppa-joe kapppa-joe approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@duncanc19 @kapppa-joe @ssrome