Bulk upload - Transfer staff record #6413
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
duncanc19
reviewed
Nov 11, 2024
| column: 'UNIQUEWORKERID', | ||
| error: | ||
| 'There are more than one worker with this UNIQUEWORKERID moving into the new workplace given in TRANSFERSTAFFRECORD.', | ||
| }); |
There was a problem hiding this comment.
Quite a bit of duplication with these errors, I think we've already got a couple of functions which generate errors similar to this in one of the other validation files, could see if those could be reused and if it's hassle just make a function for it here?
There was a problem hiding this comment.
Also, I know there's been talk of it being hard to find all the BU validation error/warning messages, it might be nice to have an object at the top of the file with the different error messages and then in the code it would just be something along the lines of addError(JSONWorker, errors.sameRefsMovingToWorkplace)
duncanc19
approved these changes
Nov 11, 2024
…EW worker and TRANSFER worker
…alidateMainJobRole
kapppa-joe
force-pushed
the
spike/poc-for-bu-transfer-staff-record-column
branch
from
332d7f6 to
a43e4e6
Compare
…oth CHGUNIQUEWRKID and TRANSFERSTAFFRECORD
… and move staff at same time
…sting ref in workplace
…ce with worker with same ref, even if the worker's ID is being changed
…g workerEntity not found in establishment
…rking as sort takes a function with two params for comparison
…d-and-staff-transfer Fix: Allow change id and staff transfer
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Work done
Tests
Does this PR include tests for the changes introduced?