Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature branch/qualification accordion #6409

Merged
merged 43 commits into from
Nov 14, 2024
Merged

Feature branch/qualification accordion #6409

merged 43 commits into from
Nov 14, 2024

Conversation

duncanc19
Copy link
Collaborator

Qualification accordion feature branch

Work done

Tests

Does this PR include tests for the changes introduced?

  • Yes
  • No, I found it difficult to test
  • No, they are not required for this change

kapppa-joe and others added 30 commits October 1, 2024 12:10
@kapppa-joe
add a new component for select-qualification-type
6c0b50d
@duncanc19
Update add-edit-qualification to have single form with year achieved …
55e2f91 
…and notes, qualification name and type stubbed
@duncanc19
Delete qualification-form component and move content into add-edit-qu…
5871c92 
…alification
@kapppa-joe
populate the content of qualification accordions
2e51a06
@duncanc19
Add tests for prefilling inputs when existing qualification
80405d8
@duncanc19
Add displaying qualification name and group for existing qualifications
473b1d1
@duncanc19
Update existing qualifications with correct id and group
ada5982
@kapppa-joe
store selected qualification to qualificationService on submit
e859d37
@duncanc19
Fix bug where character count not updated when existing notes
dabfe30
@kapppa-joe
add validation and prefill form
8405e6c
@duncanc19
Move notes box into reveal
0288329
@kapppa-joe
tidy up import, remove unused OnDestroy
6c02bc1
@kapppa-joe
remove commented out lines
da3a222
@kapppa-joe
add one unit test, minor tidy ups
bd4f9f0
@kapppa-joe
amend setSelectedQualification to store the title as well
9da51e8
@kapppa-joe
add a resolver for availableQualifications
03268e0
@kapppa-joe
remove fdescribe, sort imports
45ceaca
@duncanc19
Update page to display and submit data from qualification service whe…
2334884 
…n not an existing qualification record
@kapppa-joe
patch a bug at GroupedRadioButtonAccordionComponent
63013bb
@kapppa-joe
remove unused imports
51772bc
@duncanc19
Add change link for new qualification records
25710e0
@duncanc19
Navigate back to qualification selection page if no qualification fou…
00fe3f3 
…nd in service or from params
@duncanc19
Increase gap between year achieved and notes inputs
c81b579
@duncanc19
Clear selectedQualification in service on valid submission
df4a5f9
@duncanc19
Clear data in qualification service on click of cancel
d5e9984
@kapppa-joe
address PR comments
8ad8c2f
@kapppa-joe
Merge pull request #6376 from NMDSdevopsServiceAdm/feat/1520-qualific…
8a8e504 
…ation-accordion

Feat/1520 qualification accordion
@duncanc19
Merge qualification accordion feature branch in
500c543
@duncanc19
Convert qualification type to lower case unless NVQ
a2cabc3
@duncanc19
Fix back navigation on page refresh to go to previous accordion page
f8c3783
duncanc19 and others added 13 commits October 4, 2024 10:26
@duncanc19
Set width of column for qualification title dynamically to have Chang…
93520e9 
…e link closer
@duncanc19
Use custom styling to display Change link to have fixed gap between t…
ce8bab7 
…itle and change link
@duncanc19
Reduce spacing on submit buttons
89a457a
@duncanc19
Fix cancel link on accordion page to go back to worker training record
a14e85e
@duncanc19
Merge remote-tracking branch 'origin' into featureBranch/qualificatio…
13c0b14 
…n-accordion
@duncanc19
Merge branch 'featureBranch/qualification-accordion' into feat/1521-q…
8a4ce67 
…ualification-edit-page
@duncanc19
Merge pull request #6378 from NMDSdevopsServiceAdm/feat/1521-qualific…
edd1958 
…ation-edit-page

Feat/1521 qualification edit page
@duncanc19
Merge main into branch
157002a
@duncanc19
Use training and quals summary url to ensure navigation always succes…
f6e1e16 
…sful after deletion of record
@duncanc19
Remove unneeded previousUrl
1743d39
@duncanc19
Rename training and quals summary url variable for clarity
1d1fd1b
@duncanc19
Reintroduce previousUrl to handle cases when navigated to training fr…
8f2ee0a 
…om expired/expiring training page and have worker training and qual summary as default for case where no previousUrl
@duncanc19
Merge pull request #6408 from NMDSdevopsServiceAdm/fix/navigation-aft…
da25d6f 
…er-deletion-of-training-or-qual-record

Fix/navigation after deletion of training or qual record
@duncanc19 duncanc19 merged commit a5ba36a into main Nov 14, 2024
5 checks passed
@duncanc19 duncanc19 deleted the featureBranch/qualification-accordion branch November 14, 2024 10:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kapppa-joe kapppa-joe kapppa-joe approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@duncanc19 @kapppa-joe