Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump ws, @lhci/cli, engine.io, socket.io-adapter and puppeteer in /backend #6325

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

dependabot[bot]
Copy link
Contributor

@dependabot dependabot bot commented on behalf of github Aug 21, 2024

Bumps ws to 8.17.1 and updates ancestor dependencies ws, @lhci/cli, engine.io, socket.io-adapter and puppeteer. These dependencies need to be updated together.

Updates ws from 7.5.9 to 8.17.1

Release notes

Sourced from ws's releases.

8.17.1

Bug fixes

  • Fixed a DoS vulnerability (#2231).

A request with a number of headers exceeding the[server.maxHeadersCount][] threshold could be used to crash a ws server.

const http = require('http');
const WebSocket = require('ws');
const wss = new WebSocket.Server({ port: 0 }, function () {
const chars = "!#$%&'*+-.0123456789abcdefghijklmnopqrstuvwxyz^_`|~".split('');
const headers = {};
let count = 0;
for (let i = 0; i < chars.length; i++) {
if (count === 2000) break;
for (let j = 0; j &lt; chars.length; j++) {
  const key = chars[i] + chars[j];
  headers[key] = 'x';
if (++count === 2000) break;
}

}
headers.Connection = 'Upgrade';
headers.Upgrade = 'websocket';
headers['Sec-WebSocket-Key'] = 'dGhlIHNhbXBsZSBub25jZQ==';
headers['Sec-WebSocket-Version'] = '13';
const request = http.request({
headers: headers,
host: '127.0.0.1',
port: wss.address().port
});
request.end();
});

The vulnerability was reported by Ryan LaPointe in websockets/ws#2230.

In vulnerable versions of ws, the issue can be mitigated in the following ways:

  1. Reduce the maximum allowed length of the request headers using the [--max-http-header-size=size][] and/or the [maxHeaderSize][] options so that no more headers than the server.maxHeadersCount limit can be sent.

... (truncated)

Commits
  • 3c56601 [dist] 8.17.1
  • e55e510 [security] Fix crash when the Upgrade header cannot be read (#2231)
  • 6a00029 [test] Increase code coverage
  • ddfe4a8 [perf] Reduce the amount of crypto.randomFillSync() calls
  • b73b118 [dist] 8.17.0
  • 29694a5 [test] Use the highWaterMark variable
  • 934c9d6 [ci] Test on node 22
  • 1817bac [ci] Do not test on node 21
  • 96c9b3d [major] Flip the default value of allowSynchronousEvents (#2221)
  • e5f32c7 [fix] Emit at most one event per event loop iteration (#2218)
  • Additional commits viewable in compare view

Updates @lhci/cli from 0.7.2 to 0.14.0

Release notes

Sourced from @​lhci/cli's releases.

v0.14.0

v0.14.0 (2024-06-20)

  • feat: upgrade to lighthouse 12.0.0 (#1035) (cc564a6), closes #1035
  • feat: support .htm files in fallback server (#1033) (2ed3b31), closes #1033
  • feat: increase column width for project name (#1006) (8fe7e8d), closes #1006
  • feat: upgrade to lighthouse 12.1.0 (#1046) (8a0e3dc), closes #1046
  • feat(cli): add --lhr to assert command to load LHRs from anywhere (#1024) (19c7ca6), closes #1024
  • fix(cli): use ProxyAgent instead of HttpsProxyAgent (#1038) (cdf4605), closes #1038
  • chore: bump lhci references to 0.13 (083d639)
  • misc(release): remove hulk from release process (mostly) (36e629e)

BREAKING CHANGE

  • upgrade to lighthouse 12.1.0

v0.13.0

v0.13.0 (2023-12-15)

  • feat: sort projects by name (#976) (2bf36f4), closes #976
  • feat: upgrade to lighthouse 11.4.0 (#991) (7cc4ba8), closes #991
  • feat(cli): add static dir file discovery depth flag (#940) (de1614e), closes #940
  • fix(docker): added extra environment variable to lhci-client Dockerfile for puppeteer executable (#9 (f28992b), closes #916
  • docs: add *.cjs to supported config extensions (#975) (a706c54), closes #975
  • docs: fix typo of puppeterScript to puppeteerScript (#979) (b16e48d), closes #979
  • tests: use more random name for sql test file (#986) (72b79d8), closes #986
  • chore: update docker images with latest version (9d710c1)
  • chore: rebaseline snapshot images (#980) (7e75eed), closes #980
  • chore: remove jest worker limit (#981) (91bfbf9), closes #981
  • chore: set jest max workers to 1 (#985) (200b915), closes #985
  • chore: bump to node 18 (#989) (c5bde95), closes #989
  • chore(deps): run yarn audit fix to upgrade many deps (#992) (3ea9955), closes #992
  • chore(deps): upgrade to storybook 7.6.4, preact 10.19.3, esbuild 0.19.9 (#990) (5d30e52), closes #990
  • chore(deps): bump lodash from 4.17.11 to 4.17.21 (#956) (00b2c91), closes #956
  • chore(deps): bump handlebars from 4.1.2 to 4.7.8 (#978) (c183f9f), closes #978
  • chore(deps): bump @​babel/traverse from 7.4.3 to 7.23.6 (#987) (60693f0), closes #987
  • chore(deps): bump browserify-sign from 4.0.4 to 4.2.2 (#957) (e40dec0), closes #957
  • chore(deps): bump tree-kill from 1.2.1 to 1.2.2 (#952) (2bd2e9c), closes #952
  • chores(deps): upgrade puppeteer to 21.6.1 (#988) (939ef03), closes #988
  • chores(deps): upgrade umzug to 3.4.0 (#984) (a3ee284), closes #984
  • chores(deps): upgrade typescript to 5.3.3 (#983) (29a67d9), closes #983
  • chores(deps): upgrade sequelize to 6.35.2 (#982) (5b94d30), closes #982
  • collect: use new headless mode (#907) (2cf4dc0), closes #907
  • Readme: Update Heroku mentions (#931) (b124841), closes #931
  • Instruct users to install Lighthouse CI 0.12 (#927) (72db595), closes #927
  • catch localStorage exceptions in difftool (#938) (332888a), closes #938

... (truncated)

Commits
  • bbaa624 misc(release): remove hulk from release process (mostly)
  • cdf4605 fix(cli): use ProxyAgent instead of HttpsProxyAgent (#1038)
  • 8a0e3dc feat: upgrade to lighthouse 12.1.0 (#1046)
  • 8fe7e8d feat: increase column width for project name (#1006)
  • 2ed3b31 feat: support .htm files in fallback server (#1033)
  • cc564a6 feat: upgrade to lighthouse 12.0.0 (#1035)
  • 19c7ca6 feat(cli): add --lhr to assert command to load LHRs from anywhere (#1024)
  • 083d639 chore: bump lhci references to 0.13
  • 7cc4ba8 feat: upgrade to lighthouse 11.4.0 (#991)
  • 3ea9955 chore(deps): run yarn audit fix to upgrade many deps (#992)
  • Additional commits viewable in compare view
Maintainer changes

This version was pushed to npm by hoten, a new releaser for @​lhci/cli since your current version.


Updates engine.io from 6.5.4 to 6.5.5

Release notes

Sourced from engine.io's releases.

6.5.5

This release contains a bump of the ws dependency, which includes an important security fix.

Advisory: GHSA-3h5v-q93c-6h6q

Bug Fixes

Links

Changelog

Sourced from engine.io's changelog.

6.5.5 (2024-06-18)

This release contains a bump of the ws dependency, which includes an important security fix.

Advisory: GHSA-3h5v-q93c-6h6q

Bug Fixes

Dependencies

Commits

Updates socket.io-adapter from 2.5.2 to 2.5.5

Release notes

Sourced from socket.io-adapter's releases.

2.5.4

Bug Fixes

  • ensure the order of the commands (a13f35f)
  • types: ensure compatibility with TypeScript < 4.5 (ca397f3)

Links

2.5.3

Two abstract classes were imported from the Redis adapter repository:

  • the ClusterAdapter class, which manages the messages sent between the server instances of the cluster
  • the ClusterAdapterWithHeartbeat class, which extends the ClusterAdapter and adds a heartbeat mechanism in order to check the healthiness of the other instances

Other adapters can then just extend those classes and only have to implement the pub/sub mechanism (and not the internal chit-chat protocol):

class MyAdapter extends ClusterAdapterWithHeartbeat {
  constructor(nsp, pubSub, opts) {
    super(nsp, opts);
    this.pubSub = pubSub;
    pubSub.subscribe("main-channel", (message) => this.onMessage(message));
    pubSub.subscribe("specific-channel#" + this.uid, (response) => this.onResponse(response));
  }
doPublish(message) {
return this.pubSub.publish("main-channel", message);
}
doPublishResponse(requesterUid, response) {
return this.pubSub.publish("specific-channel#" + requesterUid, response);
}
}

Besides, the number of "timeout reached: only x responses received out of y" errors (which can happen when a server instance leaves the cluster) should be greatly reduced by this commit.

Bug Fixes

  • cluster: fix count in fetchSockets() method (80af4e9)
  • cluster: notify the other nodes when closing (0e23ff0)

Performance Improvements

  • cluster: use timer.refresh() (d99a71b)

... (truncated)

Changelog

Sourced from socket.io-adapter's changelog.

2.5.5 (2024-06-18)

This release contains a bump of the ws dependency, which includes an important security fix.

Advisory: GHSA-3h5v-q93c-6h6q

2.5.4 (2024-02-22)

Bug Fixes

  • ensure the order of the commands (a13f35f)
  • types: ensure compatibility with TypeScript < 4.5 (ca397f3)

2.5.3 (2024-02-21)

Two abstract classes were imported from the Redis adapter repository:

  • the ClusterAdapter class, which manages the messages sent between the server instances of the cluster
  • the ClusterAdapterWithHeartbeat class, which extends the ClusterAdapter and adds a heartbeat mechanism in order to check the healthiness of the other instances

Other adapters can then just extend those classes and only have to implement the pub/sub mechanism (and not the internal chit-chat protocol):

class MyAdapter extends ClusterAdapterWithHeartbeat {
  constructor(nsp, pubSub, opts) {
    super(nsp, opts);
    this.pubSub = pubSub;
    pubSub.subscribe("main-channel", (message) => this.onMessage(message));
    pubSub.subscribe("specific-channel#" + this.uid, (response) => this.onResponse(response));
  }
doPublish(message) {
return this.pubSub.publish("main-channel", message);
}
doPublishResponse(requesterUid, response) {
return this.pubSub.publish("specific-channel#" + requesterUid, response);
}
}

Besides, the number of "timeout reached: only x responses received out of y" errors (which can happen when a server instance leaves the cluster) should be greatly reduced by this commit.

Bug Fixes

... (truncated)

Commits
  • 05a190a chore(release): 6.5.5
  • 93fe190 chore(deps): bump ws from 8.11.0 to 8.17.1 (#93)
  • 5eae5a0 chore(release): 2.5.4
  • 005d546 ci: test with older TypeScript version
  • a13f35f fix: ensure the order of the commands
  • 207c0db refactor: break circular dependency (2)
  • abc93a9 refactor: break circular dependency (1)
  • 9d4c4a7 refactor(cluster): export ClusterAdapterOptions and MessageType types
  • ca397f3 fix(types): ensure compatibility with TypeScript < 4.5
  • 549156c chore(release): 2.5.3
  • Additional commits viewable in compare view

Updates puppeteer from 13.7.0 to 23.1.1

Release notes

Sourced from puppeteer's releases.

puppeteer-core: v23.1.1

23.1.1 (2024-08-21)

Bug Fixes

puppeteer: v23.1.1

23.1.1 (2024-08-21)

Miscellaneous Chores

  • puppeteer: Synchronize puppeteer versions

Dependencies

  • The following workspace dependencies were updated
    • dependencies
      • puppeteer-core bumped from 23.1.0 to 23.1.1

puppeteer-core: v23.1.0

23.1.0 (2024-08-14)

Features

  • improve type inference for selectors by adopting "typed-query-selector" (#12950) (77b729e)
  • support signal in WaitFor functions (#12926) (67e3be8)

Bug Fixes

Dependencies

  • The following workspace dependencies were updated
    • dependencies
      • @​puppeteer/browsers bumped from 2.3.0 to 2.3.1

puppeteer: v23.1.0

23.1.0 (2024-08-14)

... (truncated)

Commits
  • 2c4a57b chore: release main (#12976)
  • d934cf5 fix: roll to Firefox 129.0.2 (#12987)
  • 69f9bca chore(deps-dev): Bump the dev-dependencies group across 1 directory with 15 u...
  • 26d54e3 chore(deps): Bump the all group across 1 directory with 9 updates (#12970)
  • 615823e ci: add cache to job (#12980)
  • e2277fa build: abort clean.mjs if not in a git repository (#12981)
  • 6d55c99 chore(deps): Bump the all group with 2 updates (#12971)
  • bfdc758 ci(browsers): pin Firefox under test to stable (#12977)
  • c9c5f13 chore(deps): Bump node from 1ae9ba8 to d3c8aba in /docker in the all grou...
  • b2b93d8 build: resolveDownloadPath should respect channel for Firefox (#12978)
  • Additional commits viewable in compare view
Maintainer changes

This version was pushed to npm by google-wombot, a new releaser for puppeteer since your current version.


Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.


Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot show <dependency name> ignore conditions will show all of the ignore conditions of the specified dependency
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)
    You can disable automated security fix PRs for this repo from the Security Alerts page.

Bumps [ws](https://github.com/websockets/ws) to 8.17.1 and updates ancestor dependencies [ws](https://github.com/websockets/ws), [@lhci/cli](https://github.com/GoogleChrome/lighthouse-ci), [engine.io](https://github.com/socketio/engine.io), [socket.io-adapter](https://github.com/socketio/socket.io-adapter) and [puppeteer](https://github.com/puppeteer/puppeteer). These dependencies need to be updated together.


Updates `ws` from 7.5.9 to 8.17.1
- [Release notes](https://github.com/websockets/ws/releases)
- [Commits](websockets/ws@7.5.9...8.17.1)

Updates `@lhci/cli` from 0.7.2 to 0.14.0
- [Release notes](https://github.com/GoogleChrome/lighthouse-ci/releases)
- [Commits](GoogleChrome/lighthouse-ci@v0.7.2...v0.14.0)

Updates `engine.io` from 6.5.4 to 6.5.5
- [Release notes](https://github.com/socketio/engine.io/releases)
- [Changelog](https://github.com/socketio/engine.io/blob/6.5.5/CHANGELOG.md)
- [Commits](socketio/engine.io@6.5.4...6.5.5)

Updates `socket.io-adapter` from 2.5.2 to 2.5.5
- [Release notes](https://github.com/socketio/socket.io-adapter/releases)
- [Changelog](https://github.com/socketio/socket.io-adapter/blob/2.5.5/CHANGELOG.md)
- [Commits](socketio/socket.io-adapter@2.5.2...2.5.5)

Updates `puppeteer` from 13.7.0 to 23.1.1
- [Release notes](https://github.com/puppeteer/puppeteer/releases)
- [Changelog](https://github.com/puppeteer/puppeteer/blob/main/release-please-config.json)
- [Commits](puppeteer/puppeteer@v13.7.0...puppeteer-v23.1.1)

---
updated-dependencies:
- dependency-name: ws
  dependency-type: indirect
- dependency-name: "@lhci/cli"
  dependency-type: direct:development
- dependency-name: engine.io
  dependency-type: indirect
- dependency-name: socket.io-adapter
  dependency-type: indirect
- dependency-name: puppeteer
  dependency-type: direct:development
...

Signed-off-by: dependabot[bot] <[email protected]>
@dependabot dependabot bot added the dependencies Pull requests that update a dependency file label Aug 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file
Projects
None yet
Development

Successfully merging this pull request may close these issues.

0 participants