Create migration to ensure workplaces with CQC status change records have parent approval record #6307
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…have become a parent approval records
ssrome
approved these changes
Jul 30, 2024
duncanc19
deleted the
fix/1476-update-parent-approval-for-workplaces-with-cqc-change-record
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
The previous fix PR created a migration to add become a parent records to parent workplaces with no approval record. This worked on the assumption that these accounts would have no records in the Approvals table. However, workplaces with CQC status change records were not included in the update. This PR ensures those workplaces are also updated.
Work done
Tests
Does this PR include tests for the changes introduced?