Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix/remove wdf report call in nhs api #6292

Merged
merged 5 commits into from
Aug 21, 2024

Conversation

duncanc19
Copy link
Collaborator

@duncanc19 duncanc19 commented Jul 12, 2024

Work done

  • Changed NHS API endpoint to retrieve all data from Establishment table and add workers to the query
  • Refactored database calls to ensure the same data was being returned for all workplace types

Reason

All of the data required for this endpoint is available in the Establishment and Worker tables. By using the wdfsummaryreport function, a table was being generated for all workplaces each time the endpoint was hit which seemed fine in staging but could have been a problem when there are large amounts of live data.

Tests

Does this PR include tests for the changes introduced?

  • Yes
  • No, I found it difficult to test
  • No, they are not required for this change

@duncanc19 duncanc19 merged commit 30ba24a into main Aug 21, 2024
5 checks passed
@duncanc19 duncanc19 deleted the fix/remove-wdf-report-call-in-nhs-api branch August 21, 2024 17:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants