Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix/failed test #6082

Merged
merged 2 commits into from
Jan 30, 2024
Merged

Fix/failed test #6082

merged 2 commits into from
Jan 30, 2024

Conversation

Zuhal-Ayob
Copy link
Collaborator

Work done

  • Revert the regex and fixed failed test

Tests

Does this PR include tests for the changes introduced?

  • Yes
  • No, I found it difficult to test
  • No, they are not required for this change

Jonopono123
Jonopono123 approved these changes Jan 30, 2024
View reviewed changes
Copy link
Collaborator

@Jonopono123 Jonopono123 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, nice work

@Zuhal-Ayob Zuhal-Ayob merged commit 6c76bf7 into main Jan 30, 2024
5 checks passed
@Zuhal-Ayob Zuhal-Ayob deleted the fix/failedTest branch January 30, 2024 16:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Jonopono123 Jonopono123 Jonopono123 approved these changes

@jpmaHub jpmaHub jpmaHub approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Zuhal-Ayob @jpmaHub @Jonopono123