Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fixed the service unavaliable page href #6028

Closed
wants to merge 1 commit into from

Conversation

Zuhal-Ayob
Copy link
Collaborator

Work done

  • fix the href for service unavailable

Tests

Does this PR include tests for the changes introduced?

  • Yes
  • No, I found it difficult to test
  • No, they are not required for this change

Copy link

codeclimate bot commented Jan 8, 2024

Code Climate has analyzed commit 5042677 and detected 0 issues on this pull request.

View more on Code Climate.

Copy link
Contributor

@sbt92 sbt92 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link

codecov bot commented Jan 8, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 43.50%. Comparing base (1b362a9) to head (5042677).
Report is 876 commits behind head on test.

❗ There is a different number of reports uploaded between BASE (1b362a9) and HEAD (5042677). Click for more details.

HEAD has 1 upload less than BASE
Flag BASE (1b362a9) HEAD (5042677)
2 1
Additional details and impacted files
@@            Coverage Diff             @@
##             test    #6028      +/-   ##
==========================================
- Coverage   53.04%   43.50%   -9.54%     
==========================================
  Files        1151      455     -696     
  Lines       37924    18513   -19411     
  Branches     4681        0    -4681     
==========================================
- Hits        20116     8055   -12061     
+ Misses      13815    10458    -3357     
+ Partials     3993        0    -3993     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@duncanc19 duncanc19 closed this Jan 13, 2025
@duncanc19 duncanc19 deleted the fix/serviceunavaliable branch January 13, 2025 09:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants