Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add app runner endpoint to the routes #5985

Merged
merged 6 commits into from
Dec 20, 2023
Merged

Add app runner endpoint to the routes #5985

merged 6 commits into from
Dec 20, 2023

Conversation

jpmaHub
Copy link
Contributor

@jpmaHub jpmaHub commented Nov 15, 2023

Work done

  • Added apprunner environment variable to the routes
  • Apprunner endpoint to the environment ts file

Tests

Does this PR include tests for the changes introduced?

  • Yes
  • No, I found it difficult to test
  • No, they are not required for this change

Copy link

codecov bot commented Nov 15, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (6474d36) 53.04% compared to head (46a0794) 43.51%.

Additional details and impacted files
@@            Coverage Diff             @@
##             test    #5985      +/-   ##
==========================================
- Coverage   53.04%   43.51%   -9.53%     
==========================================
  Files        1151      455     -696     
  Lines       37924    18513   -19411     
  Branches     4681        0    -4681     
==========================================
- Hits        20116     8056   -12060     
+ Misses      13815    10457    -3358     
+ Partials     3993        0    -3993     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@magicmilo magicmilo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is failing in CircleCI

Copy link

codeclimate bot commented Dec 20, 2023

Code Climate has analyzed commit 46a0794 and detected 93 issues on this pull request.

Here's the issue category breakdown:

Category Count
Duplication 93

View more on Code Climate.

@sbt92 sbt92 merged commit 1b362a9 into test Dec 20, 2023
8 of 10 checks passed
@sbt92 sbt92 deleted the feat/apprunner-endpoint branch December 20, 2023 12:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants