Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor Buildspec files #5984

Merged
merged 1 commit into from
Nov 15, 2023
Merged

Refactor Buildspec files #5984

merged 1 commit into from
Nov 15, 2023

Conversation

Zuhal-Ayob
Copy link
Collaborator

@Zuhal-Ayob Zuhal-Ayob commented Nov 15, 2023

Work done

  • Refactor build spec
  • Create frontend build spec for each environment
  • Changed the deployment so it goes into each frontend environment

Tests

Does this PR include tests for the changes introduced?

  • Yes
  • No, I found it difficult to test
  • No, they are not required for this change

Copy link

codeclimate bot commented Nov 15, 2023

Code Climate has analyzed commit 2f3333d and detected 0 issues on this pull request.

View more on Code Climate.

Copy link

codecov bot commented Nov 15, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (5f16265) 54.19% compared to head (2f3333d) 54.19%.

Additional details and impacted files
@@            Coverage Diff             @@
##             test    #5984      +/-   ##
==========================================
- Coverage   54.19%   54.19%   -0.01%     
==========================================
  Files        1139     1139              
  Lines       37909    37909              
  Branches     5104     5104              
==========================================
- Hits        20545    20544       -1     
- Misses      12921    12922       +1     
  Partials     4443     4443              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@sbt92 sbt92 merged commit f837a69 into test Nov 15, 2023
6 of 7 checks passed
@sbt92 sbt92 deleted the feat/buildSpecRefactor branch November 15, 2023 13:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants