Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add back to parent component #5982

Closed
wants to merge 1 commit into from
Closed

Conversation

ssrome
Copy link
Collaborator

@ssrome ssrome commented Nov 3, 2023

Work done

Tests

Does this PR include tests for the changes introduced?

  • Yes
  • No, I found it difficult to test
  • No, they are not required for this change

@@ -0,0 +1,535 @@
import { NgModule } from '@angular/core';
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

File selected-workplace-routing.module.ts has 527 lines of code (exceeds 250 allowed). Consider refactoring.

public parentName: string;
public workplace: Establishment;

constructor(
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Similar blocks of code found in 19 locations. Consider refactoring.

title: 'User has been added',
},
},
{
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Similar blocks of code found in 2 locations. Consider refactoring.

title: 'Training and qualifications record',
},
},
{
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Similar blocks of code found in 12 locations. Consider refactoring.

title: 'Benchmarks',
},
},
{
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Similar blocks of code found in 12 locations. Consider refactoring.

Copy link

codeclimate bot commented Nov 3, 2023

Code Climate has analyzed commit 7810945 and detected 26 issues on this pull request.

Here's the issue category breakdown:

Category Count
Complexity 1
Duplication 25

View more on Code Climate.

Copy link

codecov bot commented Nov 3, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (5f16265) 54.19% compared to head (7810945) 46.36%.

Additional details and impacted files
@@            Coverage Diff             @@
##             test    #5982      +/-   ##
==========================================
- Coverage   54.19%   46.36%   -7.83%     
==========================================
  Files        1139      448     -691     
  Lines       37909    18207   -19702     
  Branches     5104        0    -5104     
==========================================
- Hits        20545     8442   -12103     
+ Misses      12921     9765    -3156     
+ Partials     4443        0    -4443     

see 691 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ssrome ssrome closed this Nov 6, 2023
@ssrome ssrome deleted the feat/1321-home-page-no-dropdown-v3 branch November 6, 2023 12:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant