-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add back to parent component #5982
Conversation
@@ -0,0 +1,535 @@ | |||
import { NgModule } from '@angular/core'; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
File selected-workplace-routing.module.ts
has 527 lines of code (exceeds 250 allowed). Consider refactoring.
public parentName: string; | ||
public workplace: Establishment; | ||
|
||
constructor( |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Similar blocks of code found in 19 locations. Consider refactoring.
title: 'User has been added', | ||
}, | ||
}, | ||
{ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Similar blocks of code found in 2 locations. Consider refactoring.
title: 'Training and qualifications record', | ||
}, | ||
}, | ||
{ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Similar blocks of code found in 12 locations. Consider refactoring.
title: 'Benchmarks', | ||
}, | ||
}, | ||
{ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Similar blocks of code found in 12 locations. Consider refactoring.
Code Climate has analyzed commit 7810945 and detected 26 issues on this pull request. Here's the issue category breakdown:
View more on Code Climate. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## test #5982 +/- ##
==========================================
- Coverage 54.19% 46.36% -7.83%
==========================================
Files 1139 448 -691
Lines 37909 18207 -19702
Branches 5104 0 -5104
==========================================
- Hits 20545 8442 -12103
+ Misses 12921 9765 -3156
+ Partials 4443 0 -4443 ☔ View full report in Codecov by Sentry. |
Work done
Tests
Does this PR include tests for the changes introduced?