-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feat/1321 home page no dropdown #5977
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## test #5977 +/- ##
==========================================
- Coverage 54.19% 46.36% -7.83%
==========================================
Files 1139 448 -691
Lines 37909 18207 -19702
Branches 5104 0 -5104
==========================================
- Hits 20543 8441 -12102
+ Misses 12923 9766 -3157
+ Partials 4443 0 -4443 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There are accessibility issues in these changes.
src/app/shared/components/back-to-parent-link/back-to-parent-link.component.html
Outdated
Show resolved
Hide resolved
@@ -86,6 +87,21 @@ const routes: Routes = [ | |||
totalStaffRecords: TotalStaffRecordsResolver, | |||
}, | |||
}, | |||
{ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Similar blocks of code found in 2 locations. Consider refactoring.
Code Climate has analyzed commit ab98e1f and detected 4 issues on this pull request. Here's the issue category breakdown:
View more on Code Climate. |
Work done
Tests
Does this PR include tests for the changes introduced?