Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat/1321 home page no dropdown #5977

Closed
wants to merge 12 commits into from
Closed

Conversation

ssrome
Copy link
Collaborator

@ssrome ssrome commented Oct 12, 2023

Work done

Tests

Does this PR include tests for the changes introduced?

  • Yes
  • No, I found it difficult to test
  • No, they are not required for this change

@codecov
Copy link

codecov bot commented Oct 12, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (9538718) 54.19% compared to head (051a566) 46.36%.
Report is 9 commits behind head on test.

Additional details and impacted files
@@            Coverage Diff             @@
##             test    #5977      +/-   ##
==========================================
- Coverage   54.19%   46.36%   -7.83%     
==========================================
  Files        1139      448     -691     
  Lines       37909    18207   -19702     
  Branches     5104        0    -5104     
==========================================
- Hits        20543     8441   -12102     
+ Misses      12923     9766    -3157     
+ Partials     4443        0    -4443     

see 692 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

@accesslint accesslint bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There are accessibility issues in these changes.

@@ -86,6 +87,21 @@ const routes: Routes = [
totalStaffRecords: TotalStaffRecordsResolver,
},
},
{
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Similar blocks of code found in 2 locations. Consider refactoring.

@codeclimate
Copy link

codeclimate bot commented Oct 13, 2023

Code Climate has analyzed commit ab98e1f and detected 4 issues on this pull request.

Here's the issue category breakdown:

Category Count
Duplication 4

View more on Code Climate.

@ssrome ssrome closed this May 28, 2024
@ssrome ssrome deleted the feat/1321-home-page-no-dropdown branch May 28, 2024 14:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant