WIP: Feat/wdfGrantLetter #4771

ghost · 2022-03-29T15:24:04Z

Work done

Adds helper functions for interacting with Adobe Sign for creation and querying of agreements
Creates endpoints for these interactions
Creates new db tables for storing the agreement interactions.

Tests

Does this PR include tests for the changes introduced?

Yes
No, I found it difficult to test
No, they are not required for this change

…e level

…adobe sign

codeclimate · 2022-03-29T15:25:03Z

server/routes/wdf/developmentFundGrants/adobeSign/index.js

+const adobeSignBaseUrl = config.get('adobeSign.apiBaseUrl');
+const adobeApiKey = config.get('adobeSign.apiKey');
+
+module.exports.createAgreement = async (claimData, isNationalOrg) => {


Function createAgreement has 72 lines of code (exceeds 25 allowed). Consider refactoring.

codeclimate · 2022-03-29T15:25:04Z

server/models/developmentFundGrants.js

@@ -0,0 +1,50 @@
+'use strict';
+
+module.exports = function (sequelize, DataTypes) {


Function exports has 45 lines of code (exceeds 25 allowed). Consider refactoring.

lgtm-com · 2022-03-29T15:29:31Z

This pull request fixes 1 alert when merging 6bb9663 into 676edf2 - view on LGTM.com

fixed alerts:

1 for Duplicate property

lgtm-com · 2022-03-29T15:43:21Z

This pull request fixes 1 alert when merging bcf617d into 676edf2 - view on LGTM.com

fixed alerts:

1 for Duplicate property

codecov · 2022-03-29T15:51:57Z

Codecov Report

Merging #4771 (0e58b43) into test (e4b2475) will decrease coverage by 8.16%.
The diff coverage is 64.51%.

@@            Coverage Diff             @@
##             test    #4771      +/-   ##
==========================================
- Coverage   51.66%   43.49%   -8.17%     
==========================================
  Files         975      409     -566     
  Lines       38308    17407   -20901     
  Branches     4561        0    -4561     
==========================================
- Hits        19793     7572   -12221     
+ Misses      14510     9835    -4675     
+ Partials     4005        0    -4005

Impacted Files	Coverage Δ
server/config/config.js	`59.57% <ø> (ø)`
...ver/routes/establishments/wdfClaims/grantLetter.js	`0.00% <0.00%> (ø)`
server/routes/establishments/wdfClaims/index.js	`0.00% <ø> (ø)`
server/models/establishment.js	`45.52% <50.00%> (+0.07%)`	⬆️
...ts/wdfClaims/generateDevelopmentFundGrantLetter.js	`58.06% <58.06%> (ø)`
server/models/developmentFundGrants.js	`66.66% <66.66%> (ø)`
server/utils/adobeSign/index.js	`100.00% <100.00%> (ø)`
server/utils/wdfEligibilityDate.js	`83.33% <0.00%> (ø)`
...andatory-training/add-mandatory-training.module.ts
...rc/app/core/breadcrumb/journey.benchmark_metric.ts
... and 568 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e4b2475...0e58b43. Read the comment docs.

codeclimate · 2022-03-30T14:38:53Z

server/routes/wdf/developmentFundGrants/adobeSign/index.js

+const adobeSignBaseUrl = config.get('adobeSign.apiBaseUrl');
+const adobeApiKey = config.get('adobeSign.apiKey');
+
+module.exports.createAgreement = async (claimData) => {


Function createAgreement has 64 lines of code (exceeds 25 allowed). Consider refactoring.

lgtm-com · 2022-03-30T14:43:01Z

This pull request introduces 1 alert and fixes 1 when merging b4d4bb6 into 676edf2 - view on LGTM.com

new alerts:

1 for Server-side request forgery

fixed alerts:

1 for Duplicate property

Co-authored-by: M Daley <[email protected]>

codeclimate · 2022-03-31T09:50:47Z

server/models/developmentFundGrants.js

@@ -0,0 +1,54 @@
+'use strict';
+
+module.exports = function (sequelize, DataTypes) {


Function exports has 49 lines of code (exceeds 25 allowed). Consider refactoring.

lgtm-com · 2022-03-31T09:53:56Z

This pull request introduces 1 alert and fixes 1 when merging 21bfebc into 676edf2 - view on LGTM.com

new alerts:

1 for Server-side request forgery

fixed alerts:

1 for Duplicate property

Co-authored-by: M Daley <[email protected]>

codeclimate · 2022-03-31T13:56:10Z

server/models/developmentFundGrants.js

@@ -0,0 +1,57 @@
+'use strict';
+
+module.exports = function (sequelize, DataTypes) {


Function exports has 52 lines of code (exceeds 25 allowed). Consider refactoring.

codeclimate · 2022-03-31T13:56:10Z

server/routes/wdf/developmentFundGrants/generateDevelopmentFundGrantLetter.js

+const DevelopmentFundGrants = require('../../../models/developmentFundGrants');
+const { createAgreement, queryAgreementStatus } = require('./adobeSign');
+
+const generateDevelopmentFundGrantLetter = async (req, res, next) => {


Function generateDevelopmentFundGrantLetter has 32 lines of code (exceeds 25 allowed). Consider refactoring.

lgtm-com · 2022-03-31T14:01:03Z

This pull request introduces 1 alert and fixes 1 when merging 027798b into 676edf2 - view on LGTM.com

new alerts:

1 for Server-side request forgery

fixed alerts:

1 for Duplicate property

…g of db

codeclimate · 2022-03-31T16:12:36Z

server/models/developmentFundGrants.js

@@ -0,0 +1,68 @@
+'use strict';
+
+module.exports = function (sequelize, DataTypes) {


Function exports has 62 lines of code (exceeds 25 allowed). Consider refactoring.

lgtm-com · 2022-03-31T16:18:11Z

This pull request introduces 1 alert and fixes 1 when merging 0cda855 into 676edf2 - view on LGTM.com

new alerts:

1 for Server-side request forgery

fixed alerts:

1 for Duplicate property

lgtm-com · 2022-04-01T08:33:22Z

This pull request introduces 1 alert and fixes 1 when merging 200c139 into 676edf2 - view on LGTM.com

new alerts:

1 for Server-side request forgery

fixed alerts:

1 for Duplicate property

…ys accurate

codeclimate · 2022-04-01T11:27:58Z

server/models/developmentFundGrants.js

@@ -0,0 +1,88 @@
+'use strict';
+
+module.exports = function (sequelize, DataTypes) {


Function exports has 82 lines of code (exceeds 25 allowed). Consider refactoring.

codeclimate · 2022-04-01T11:27:58Z

server/routes/wdf/developmentFundGrants/generateDevelopmentFundGrantLetter.js

+const models = require('../../../models');
+const { createAgreement, queryAgreementStatus } = require('./adobeSign');
+
+const generateDevelopmentFundGrantLetter = async (req, res, next) => {


Function generateDevelopmentFundGrantLetter has 28 lines of code (exceeds 25 allowed). Consider refactoring.

lgtm-com · 2022-04-01T11:32:18Z

This pull request introduces 1 alert and fixes 1 when merging 700b7b5 into 676edf2 - view on LGTM.com

new alerts:

1 for Server-side request forgery

fixed alerts:

1 for Duplicate property

Co-authored-by: M Daley <[email protected]>

lgtm-com · 2022-04-01T13:27:15Z

This pull request introduces 2 alerts and fixes 1 when merging b89076d into 676edf2 - view on LGTM.com

new alerts:

1 for Unused variable, import, function or class
1 for Server-side request forgery

fixed alerts:

1 for Duplicate property

Co-authored-by: M Daley <[email protected]>

codeclimate · 2022-04-01T14:41:28Z

server/utils/adobeSign/index.js

+const adobeSignBaseUrl = config.get('adobeSign.apiBaseUrl');
+const adobeApiKey = config.get('adobeSign.apiKey');
+
+module.exports.createAgreement = async (claimData) => {


Function createAgreement has 64 lines of code (exceeds 25 allowed). Consider refactoring.

codeclimate · 2022-04-01T14:41:28Z

server/routes/establishments/wdfClaims/generateDevelopmentFundGrantLetter.js

+const models = require('../../../models');
+const { createAgreement, queryAgreementStatus } = require('../../../utils/adobeSign');
+
+const generateDevelopmentFundGrantLetter = async (req, res, next) => {


Function generateDevelopmentFundGrantLetter has 28 lines of code (exceeds 25 allowed). Consider refactoring.

lgtm-com · 2022-04-01T14:46:00Z

This pull request introduces 2 alerts and fixes 1 when merging 0e8c872 into 676edf2 - view on LGTM.com

new alerts:

2 for Unused variable, import, function or class

fixed alerts:

1 for Duplicate property

lgtm-com · 2022-04-01T14:57:43Z

This pull request introduces 2 alerts and fixes 1 when merging 9edd46d into 676edf2 - view on LGTM.com

new alerts:

2 for Unused variable, import, function or class

fixed alerts:

1 for Duplicate property

codeclimate · 2022-04-01T15:26:28Z

server/models/developmentFundGrants.js

@@ -0,0 +1,83 @@
+'use strict';
+
+module.exports = function (sequelize, DataTypes) {


Function exports has 77 lines of code (exceeds 25 allowed). Consider refactoring.

lgtm-com · 2022-04-01T15:30:21Z

This pull request introduces 2 alerts and fixes 1 when merging 763a0ec into 676edf2 - view on LGTM.com

new alerts:

2 for Unused variable, import, function or class

fixed alerts:

1 for Duplicate property

lgtm-com · 2022-04-04T09:38:44Z

This pull request introduces 2 alerts and fixes 1 when merging 38b8551 into 676edf2 - view on LGTM.com

new alerts:

2 for Unused variable, import, function or class

fixed alerts:

1 for Duplicate property

…ith database value

codeclimate · 2022-04-04T11:46:43Z

server/models/developmentFundGrants.js

@@ -0,0 +1,105 @@
+'use strict';
+
+module.exports = function (sequelize, DataTypes) {


Function exports has 97 lines of code (exceeds 25 allowed). Consider refactoring.

codeclimate · 2022-04-04T11:46:43Z

server/routes/establishments/wdfClaims/generateDevelopmentFundGrantLetter.js

+const models = require('../../../models');
+const { createAgreement, queryAgreementStatus } = require('../../../utils/adobeSign');
+
+const generateDevelopmentFundGrantLetter = async (req, res, next) => {


Function generateDevelopmentFundGrantLetter has 27 lines of code (exceeds 25 allowed). Consider refactoring.

codeclimate · 2022-04-04T11:46:43Z

server/models/developmentFundGrants.js

+    });
+  };
+
+  DevelopmentFundGrants.updateStatus = async function (establishmentId, status) {


Similar blocks of code found in 2 locations. Consider refactoring.

lgtm-com · 2022-04-04T11:51:35Z

This pull request introduces 2 alerts and fixes 1 when merging 52235ff into 676edf2 - view on LGTM.com

new alerts:

2 for Unused variable, import, function or class

fixed alerts:

1 for Duplicate property

codeclimate · 2022-04-04T15:19:58Z

Code Climate has analyzed commit 0e58b43 and detected 4 issues on this pull request.

Here's the issue category breakdown:

Category	Count
Complexity	3
Duplication	1

View more on Code Climate.

lgtm-com · 2022-04-04T15:24:14Z

This pull request introduces 2 alerts and fixes 1 when merging 0e58b43 into 676edf2 - view on LGTM.com

new alerts:

2 for Unused variable, import, function or class

fixed alerts:

1 for Duplicate property

Matthew Daley added 9 commits March 28, 2022 14:40

adds code outline for adobe sign token fetching function

3d69a54

adds scaffold for creating adobe sign agreements

0369b21

adds national org boolean to determine the grant letter template:

475d09f

removes generateToken function as using key instead

bbaa752

adds adobe sign function to query an agreement by the ID

3275c8e

renames utils folder and throws errors so they can be handled at rout…

7a6a943

…e level

adds config details required for echo sign

ce86fb9

adds migrations and model for db setup

a3ac11e

renames folder to match db table name and removes unsed variable for …

6bb9663

…adobe sign

codeclimate bot reviewed Mar 29, 2022

View reviewed changes

fix path in tests

bcf617d

Matthew Daley added 5 commits March 30, 2022 11:29

updates variables passed and tests associated with updates

21dc045

removes forename from adobe sign payload

1e386ff

adds endpoint routing for wdf grant letters

b1e49d3

adds model for fetching WDF data

0df0dc6

adds route handler for generating WDF grant letter

b4d4bb6

codeclimate bot reviewed Mar 30, 2022

View reviewed changes

update the migration and model

21bfebc

Co-authored-by: M Daley <[email protected]>

codeclimate bot reviewed Mar 31, 2022

View reviewed changes

save aggrement data

027798b

Co-authored-by: M Daley <[email protected]>

codeclimate bot reviewed Mar 31, 2022

View reviewed changes

refactors to have the method within the model to allow easier stubbin…

0cda855

…g of db

codeclimate bot reviewed Mar 31, 2022

View reviewed changes

updates test with method and url

200c139

Matthew Daley added 3 commits April 1, 2022 12:10

fixes test issue with stub

1ca898e

updates db model and migration

80ed878

saves the Adobe Sign status rather than mapping as status is not alwa…

700b7b5

…ys accurate

codeclimate bot reviewed Apr 1, 2022

View reviewed changes

Zuhal-Ayob added 2 commits April 1, 2022 14:17

get status from echoSign

e1aa307

Co-authored-by: M Daley <[email protected]>

fix merge conflicts

b89076d

Co-authored-by: M Daley <[email protected]>

move the files to the right place

0e8c872

Co-authored-by: M Daley <[email protected]>

codeclimate bot reviewed Apr 1, 2022

View reviewed changes

updates tests following folder restructure

9edd46d

removes complete date from migrations and drops type on down migration

763a0ec

codeclimate bot reviewed Apr 1, 2022

View reviewed changes

changes date sent to date created due to adobe sign meta data available

38b8551

Zuhal-Ayob added 2 commits April 4, 2022 12:41

get the echoSign status and save it to the database after comparing w…

64bbe0e

…ith database value

updated with brunch

52235ff

codeclimate bot reviewed Apr 4, 2022

View reviewed changes

fixes broken tests due to conflict resolution

0e58b43

ghost assigned Zuhal-Ayob Apr 19, 2022

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

WIP: Feat/wdfGrantLetter #4771

WIP: Feat/wdfGrantLetter #4771

ghost commented Mar 29, 2022 •

edited by ghost

Loading

codeclimate bot Mar 29, 2022

codeclimate bot Mar 29, 2022

lgtm-com bot commented Mar 29, 2022

lgtm-com bot commented Mar 29, 2022

codecov bot commented Mar 29, 2022 •

edited

Loading

codeclimate bot Mar 30, 2022

lgtm-com bot commented Mar 30, 2022

codeclimate bot Mar 31, 2022

lgtm-com bot commented Mar 31, 2022

codeclimate bot Mar 31, 2022

codeclimate bot Mar 31, 2022

lgtm-com bot commented Mar 31, 2022

codeclimate bot Mar 31, 2022

lgtm-com bot commented Mar 31, 2022

lgtm-com bot commented Apr 1, 2022

codeclimate bot Apr 1, 2022

codeclimate bot Apr 1, 2022

lgtm-com bot commented Apr 1, 2022

lgtm-com bot commented Apr 1, 2022

codeclimate bot Apr 1, 2022

codeclimate bot Apr 1, 2022

lgtm-com bot commented Apr 1, 2022

lgtm-com bot commented Apr 1, 2022

codeclimate bot Apr 1, 2022

lgtm-com bot commented Apr 1, 2022

lgtm-com bot commented Apr 4, 2022

codeclimate bot Apr 4, 2022

codeclimate bot Apr 4, 2022

codeclimate bot Apr 4, 2022

lgtm-com bot commented Apr 4, 2022

codeclimate bot commented Apr 4, 2022

lgtm-com bot commented Apr 4, 2022

		@@ -0,0 +1,50 @@
		'use strict';

		module.exports = function (sequelize, DataTypes) {

		@@ -0,0 +1,54 @@
		'use strict';

		module.exports = function (sequelize, DataTypes) {

		@@ -0,0 +1,57 @@
		'use strict';

		module.exports = function (sequelize, DataTypes) {

		@@ -0,0 +1,68 @@
		'use strict';

		module.exports = function (sequelize, DataTypes) {

		@@ -0,0 +1,88 @@
		'use strict';

		module.exports = function (sequelize, DataTypes) {

		@@ -0,0 +1,83 @@
		'use strict';

		module.exports = function (sequelize, DataTypes) {

		@@ -0,0 +1,105 @@
		'use strict';

		module.exports = function (sequelize, DataTypes) {

WIP: Feat/wdfGrantLetter #4771

Are you sure you want to change the base?

WIP: Feat/wdfGrantLetter #4771

Conversation

ghost commented Mar 29, 2022 • edited by ghost Loading

Work done

Tests

codeclimate bot Mar 29, 2022

Choose a reason for hiding this comment

codeclimate bot Mar 29, 2022

Choose a reason for hiding this comment

lgtm-com bot commented Mar 29, 2022

lgtm-com bot commented Mar 29, 2022

codecov bot commented Mar 29, 2022 • edited Loading

Codecov Report

codeclimate bot Mar 30, 2022

Choose a reason for hiding this comment

lgtm-com bot commented Mar 30, 2022

codeclimate bot Mar 31, 2022

Choose a reason for hiding this comment

lgtm-com bot commented Mar 31, 2022

codeclimate bot Mar 31, 2022

Choose a reason for hiding this comment

codeclimate bot Mar 31, 2022

Choose a reason for hiding this comment

lgtm-com bot commented Mar 31, 2022

codeclimate bot Mar 31, 2022

Choose a reason for hiding this comment

lgtm-com bot commented Mar 31, 2022

lgtm-com bot commented Apr 1, 2022

codeclimate bot Apr 1, 2022

Choose a reason for hiding this comment

codeclimate bot Apr 1, 2022

Choose a reason for hiding this comment

lgtm-com bot commented Apr 1, 2022

lgtm-com bot commented Apr 1, 2022

codeclimate bot Apr 1, 2022

Choose a reason for hiding this comment

codeclimate bot Apr 1, 2022

Choose a reason for hiding this comment

lgtm-com bot commented Apr 1, 2022

lgtm-com bot commented Apr 1, 2022

codeclimate bot Apr 1, 2022

Choose a reason for hiding this comment

lgtm-com bot commented Apr 1, 2022

lgtm-com bot commented Apr 4, 2022

codeclimate bot Apr 4, 2022

Choose a reason for hiding this comment

codeclimate bot Apr 4, 2022

Choose a reason for hiding this comment

codeclimate bot Apr 4, 2022

Choose a reason for hiding this comment

lgtm-com bot commented Apr 4, 2022

codeclimate bot commented Apr 4, 2022

lgtm-com bot commented Apr 4, 2022

ghost commented Mar 29, 2022 •

edited by ghost

Loading

codecov bot commented Mar 29, 2022 •

edited

Loading