Merged
Conversation
…d > 0 - Added optional "currentMod" switch in the moorings section of the YAML. (0: no current; 1: uniform current included in MoorPy).
wave_heading was assumed to be in radians but it is in degrees
- The interpolation performed in calcHydroExcitation() assumes that the wave incidences in self.BEM_headings() are sorted. This wasn't the case when the input was read from WAMIT with incidences from -180deg to 180deg due to converting the heading to a range between 0 and 360deg. Now we sort the hydro forces read from a .3 file according to the headings in the 0 to 360 deg range - There was a "If True:" that should've been removed in the past but we forgot - The BEM hydro forces weren't accounting for body orientation, but now they do
We were double counting for fowt position in the array (x_ref, y_ref). This was causing the platform and rotor visualization to be quite far from where they actually are for units not at (0,0)
- All work was done/tested in with the RM1_Floating RAFT model - Added the option to include a nacelle member in the turbine dictionary - - Only models buoyancy and hydrodynamics (but added mass and drag coefficients are set to 0) - Added better outputting for cavitation in raft_fowt and rotor - Fixed some plotting issues I created in a previous commit (need to setPosition of all FOWTs in a Model) - Deleted/commented out the section for excess inertial loads on the rotor when operating - Clean up a lot of the RM1 YAML - - Reformatted a lot of the comments - - Added 20mm end caps to increase the platform mass and be more realistic - - Added a print warning for members with a rA below rB - - Adjusted/tuned the axial added mass coefficients for the heave plates (1.0 -> 0.4) - - Increased shell density of the tower for extra components - - Added a nacelle (only counts towards buoyancy and hydrodynamics) - - - Drag set to zero, added mass to zero, also 8500 density for additional components - - Updated the other mRNA/IxRNA/IrRNA based on new OpenFAST information - - Overhang now has new convention in opposite way - - Idrivetrain controls gyroscopic damping, speed_gain controls blockage - - Cleaned up the mooring section too with the updated 4-Line mooring system - Adjusted the overhang to be the right convention in all the other designs
When transforming excitation coefficients to be relative to the incident wave heading rather than to the global frame, we were using the unsorted headings vector (heads) instead of the sorted headings vector (self.BEM_headings)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose
This PR Includes bug fixes that we found after v1.3.0:
Type of change
What types of change is it?
Testing
We still do not have tests that cover the fixes listed above, but we plan to include something in the future.
Checklist