Skip to content

Conversation

@gbarter
Copy link
Member

@gbarter gbarter commented Apr 1, 2025

  • Adds Python 3.12, 3.13.
  • Removes WISDEM api file and openmdao dependency
  • Move matplotlib to optional [plot] depedency since it is only used in the code in the plot_array function.

@gbarter gbarter requested a review from nRiccobo April 1, 2025 15:06
Copy link
Collaborator

@RHammond2 RHammond2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for making these updates to accommodate changes in WISDEM, @gbarter! I left a few really minor comments. Would you be able to also add a note to the changelog? It also seems like this is a good candidate for a patch release to ensure a smooth transition for the updates in WISDEM, or is the WISDEM release with the ORBIT changes coming at a later point in time?

@gbarter
Copy link
Member Author

gbarter commented Apr 1, 2025

Thanks for making these updates to accommodate changes in WISDEM, @gbarter! I left a few really minor comments. Would you be able to also add a note to the changelog? It also seems like this is a good candidate for a patch release to ensure a smooth transition for the updates in WISDEM, or is the WISDEM release with the ORBIT changes coming at a later point in time?

Yes, an incremental patch release is what I had in mind too!

Copy link
Collaborator

@RHammond2 RHammond2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good to me, thanks for updating the WISDEM-ORBIT interfacing, @gbarter!

@nRiccobo
Copy link
Collaborator

nRiccobo commented Apr 2, 2025

Thanks @gbarter for suggesting this changes and thanks @RHammond2 for chiming in. I'm ok with merging this into dev and then I'll do another incremental release into main by the end of this week.

@nRiccobo nRiccobo merged commit 05c0c9e into dev Apr 2, 2025
13 checks passed
@gbarter gbarter deleted the noomdao_newpythons branch April 2, 2025 20:19
@nRiccobo nRiccobo mentioned this pull request Apr 7, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants