Merge pull request #32 from yacchin1205/fix/actions-deprecated-artifact

Fix the tests
NII-cloud-operation · Nov 8, 2024 · 8376250 · 8376250
2 parents b39dbe7 + 6dd7384
commit 8376250
Show file tree

Hide file tree

Showing 6 changed files with 1,049 additions and 799 deletions.
diff --git a/.github/workflows/build.yml b/.github/workflows/build.yml
@@ -17,29 +17,48 @@ jobs:
       uses: jupyterlab/maintainer-tools/.github/actions/base-setup@v1
 
     - name: Install dependencies
-      run: python -m pip install -U 'jupyterlab>=4.0.0,<5'
+      run: |
+        set -eux
+        python -m pip install -U 'jupyterlab>=4.0.0,<5' \
+          git+https://github.com/NII-cloud-operation/Jupyter-multi_outputs.git@feature/lab
+        jupyter labextension enable lc_multi_outputs
 
     - name: Build the extension
       run: |
         set -eux
         jlpm
-        jlpm lint:check
+        jlpm run eslint:check
         python -m pip install .
 
         jupyter labextension list 2>&1 | grep -ie "lc_run_through.*OK"
         python -m jupyterlab.browser_check
 
+        jlpm install
+        cd ./ui-tests
+        jlpm install
+        jlpm playwright install
+        jlpm playwright test
+        cd ..
+
         pip install build
         python -m build --sdist
         cp dist/*.tar.gz myextension.tar.gz
-        pip uninstall -y "lc_run_through" jupyterlab
+        pip uninstall -y myextension jupyterlab
         rm -rf myextension
 
-    - uses: actions/upload-artifact@v2
+        npm pack
+        mv lc_run_through-*.tgz myextension-nodejs.tgz
+
+    - uses: actions/upload-artifact@v4
       with:
         name: myextension-sdist
         path: myextension.tar.gz
 
+    - uses: actions/upload-artifact@v4
+      with:
+        name: myextension-nodejs
+        path: myextension-nodejs.tgz
+
   test_isolated:
     needs: build
     runs-on: ubuntu-latest
@@ -52,7 +71,7 @@ jobs:
       with:
         python-version: '3.9'
         architecture: 'x64'
-    - uses: actions/download-artifact@v2
+    - uses: actions/download-artifact@v4
       with:
         name: myextension-sdist
     - name: Install and Test

diff --git a/.github/workflows/check-release.yml b/.github/workflows/check-release.yml
diff --git a/.github/workflows/release.yml b/.github/workflows/release.yml
@@ -44,7 +44,12 @@ jobs:
           yarn-
 
     - name: Install dependencies
-      run: python -m pip install -U 'jupyterlab>=4.0.0,<5'
+      run: |
+        set -eux
+        python -m pip install -U 'jupyterlab>=4.0.0,<5' \
+          git+https://github.com/NII-cloud-operation/Jupyter-multi_outputs.git@feature/lab
+        jupyter labextension enable lc_multi_outputs
+
     - name: Build the extension
       run: |
         set -eux
@@ -71,12 +76,12 @@ jobs:
         npm pack
         mv lc_run_through-*.tgz myextension-nodejs.tgz
 
-    - uses: actions/upload-artifact@v2
+    - uses: actions/upload-artifact@v4
       with:
         name: myextension-sdist
         path: myextension.tar.gz
 
-    - uses: actions/upload-artifact@v2
+    - uses: actions/upload-artifact@v4
       with:
         name: myextension-nodejs
         path: myextension-nodejs.tgz
@@ -88,10 +93,10 @@ jobs:
     steps:
     - name: Checkout
       uses: actions/checkout@v2
-    - uses: actions/download-artifact@v2
+    - uses: actions/download-artifact@v4
       with:
         name: myextension-sdist
-    - uses: actions/download-artifact@v2
+    - uses: actions/download-artifact@v4
       with:
         name: myextension-nodejs
     - name: release

diff --git a/ui-tests/package.json b/ui-tests/package.json
@@ -8,7 +8,7 @@
     "test": "jlpm playwright test"
   },
   "devDependencies": {
-    "@jupyterlab/galata": "^5.0.5",
-    "@playwright/test": "^1.37.0"
+    "@jupyterlab/galata": "^5.3.0",
+    "@playwright/test": "^1.48.2"
   }
 }
diff --git a/ui-tests/tests/lc_run_through.spec.ts b/ui-tests/tests/lc_run_through.spec.ts
@@ -148,7 +148,7 @@ test('should work unfreeze below in section button and unfreeze below all button
 
   // freeze all cells
   for(let idx of allCellIndexes) {
-    page.notebook.selectCells(idx, idx);
+    await page.notebook.selectCells(idx, idx);
     await delay(100);
     await page.locator('.run-through-toolbar-button__freeze').click();
   }
@@ -181,7 +181,7 @@ test('should work unfreeze below in section button and unfreeze below all button
 
   // freeze all cells
   for(let idx of allCellIndexes) {
-    page.notebook.selectCells(idx, idx);
+    await page.notebook.selectCells(idx, idx);
     await delay(100);
     await page.locator('.run-through-toolbar-button__freeze').click();
   }