cm/safari audio hack #440
Open
cm/safari audio hack #440
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for dailp ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Comment on lines
+11
to
+12
| // TODO: is there a place to store this instead of doing this check everytime? | ||
| // happens at this level because vite will run this server-side and crash sometimes |
There was a problem hiding this comment.
My first thoughts are to do this through React state. I figure you considered that already though. Is there anything worse about using state than running this every time?
There was a problem hiding this comment.
I'll look for a way to see if we are on the server-side, and short-circuit if we are? I wonder if that would let us make it a constant.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Get around iOS safari never triggering the "oncanplaythrough" event, which our audio player waits for before showing the play button.