Add duration bounds checking to word-for-word audio migration #351
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Goal
The purpose of this PR is to catch mismatched annotations and audio files at migration time.
Checks
end_time
and the duration of the file. For false positives, we would probably want to trim the end of the audio file anyway. Removing silence at the end of a track wouldn't affect alignment.Counting words / annotations and ensuring they match
I couldn't find a clean place to add a sanity check on
num_words == num_annotations
but here is the code for it. I originally wrote this insideAnnotatedLine::many_from_semantic
source but since that goes line by line, this would typically fail, since there are fewer words in a line than in the whole document.