refs #41211, centralize pcp image url fetch

NETivism · Aug 15, 2024 · 661bb71 · 661bb71
1 parent bd515e1
commit 661bb71
Show file tree

Hide file tree

Showing 2 changed files with 21 additions and 2 deletions.
diff --git a/CRM/Contribute/BAO/PCP.php b/CRM/Contribute/BAO/PCP.php
@@ -634,6 +634,23 @@ static function getPcpContributionPageTitle($pcpId) {
     return CRM_Core_DAO::singleValueQuery($query, $params);
   }
 
+  /**
+   * Get image urls
+   *
+   * @param int $pcpId
+   * @return array
+   */
+  public static function getPcpImages($pcpId) {
+    $dao = CRM_Core_DAO::executeQuery("SELECT file_id FROM civicrm_entity_file WHERE entity_table = 'civicrm_pcp' AND entity_id = %1", array(
+      1 => array($pcpId, 'Integer'),
+    ));
+    $files = array();
+    while($dao->fetch()) {
+      $files[] = CRM_Core_BAO_File::url($dao->file_id, $pcpId, 'civicrm_pcp');
+    }
+    return $files;
+  }
+
   /**
    * Function to get pcp block & entity id given pcp id
    *

diff --git a/CRM/Contribute/Page/PCPInfo.php b/CRM/Contribute/Page/PCPInfo.php
@@ -201,8 +201,10 @@ function run() {
 
     $honor = CRM_Contribute_BAO_PCP::honorRoll($this->_id);
 
-    if ($file_id = CRM_Core_DAO::getFieldValue('CRM_Core_DAO_EntityFile', $this->_id, 'file_id', 'entity_id')) {
-      list($src) = CRM_Core_BAO_File::url($file_id, $this->_id, 'civicrm_pcp');
+    $images = CRM_Contribute_BAO_PCP::getPcpImages($this->_id);
+    if (!empty($images)) {
+      $img = reset($images);
+      $src = $img[0];
       if ($src) {
         $bgFile = basename($src);
         $encodedSrc = str_replace($bgFile, urlencode($bgFile), $src);