Fixes for Ansible 2.15 and newer #23
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi, thanks for the PR. We'll have a look at it, but looks alright at first glance |
|
@afeefghannam89 @widhalmt If there are no objections, I'd say we merge this. |
|
Looking good from my side. Let's merge! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The whitespace characters in
tasks/cluster.ymlare causing the cluster creation to fail on control nodes with Ansible Core 2.15 and newer.Assembling the Redis ports fact in
tasks/main.ymldoes not take the plain port into consideration ifredis_tls_portis defined.Resolves #22.